From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work_sync()
Date: Tue, 19 Oct 2010 12:13:19 -0400 [thread overview]
Message-ID: <20101019121319.16f06b76@corrin.poochiereds.net> (raw)
In-Reply-To: <4CBDBF8A.8010106-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Tue, 19 Oct 2010 17:55:54 +0200
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> flush_scheduled_work() is going away.
>
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> fs/cifs/cifs_dfs_ref.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: work/fs/cifs/cifs_dfs_ref.c
> ===================================================================
> --- work.orig/fs/cifs/cifs_dfs_ref.c
> +++ work/fs/cifs/cifs_dfs_ref.c
> @@ -44,8 +44,7 @@ static void cifs_dfs_expire_automounts(s
> void cifs_dfs_release_automount_timer(void)
> {
> BUG_ON(!list_empty(&cifs_dfs_automount_list));
> - cancel_delayed_work(&cifs_dfs_automount_task);
> - flush_scheduled_work();
> + cancel_delayed_work_sync(&cifs_dfs_automount_task);
> }
>
> /**
Looks like a better way to do this anyhow.
Reviewed-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2010-10-19 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 15:55 [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work_sync() Tejun Heo
[not found] ` <4CBDBF8A.8010106-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2010-10-19 16:13 ` Jeff Layton [this message]
[not found] ` <20101019121319.16f06b76-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2010-10-19 16:15 ` Tejun Heo
[not found] ` <4CBDC419.8060909-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2010-10-19 18:22 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019121319.16f06b76@corrin.poochiereds.net \
--to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox