From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/6] CIFS: Make read call work with strict cache mode (try #2)
Date: Mon, 29 Nov 2010 02:35:55 -0500 [thread overview]
Message-ID: <20101129073555.GA4573@infradead.org> (raw)
In-Reply-To: <1290931972-2770-3-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Your patch arbitrarily shortens the read to the first vector. While
short reads for regular files are fine with Posix, it will break a lot
of userspace applications.
next prev parent reply other threads:[~2010-11-29 7:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 8:12 [PATCH 0/6] Add strict cache mode (try #4) Pavel Shilovsky
[not found] ` <1290931972-2770-1-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 8:12 ` [PATCH 1/6] CIFS: Make cifsFileInfo_put work with " Pavel Shilovsky
[not found] ` <1290931972-2770-2-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 11:23 ` Jeff Layton
2010-11-28 8:12 ` [PATCH 2/6] CIFS: Make read call work with strict cache mode (try #2) Pavel Shilovsky
[not found] ` <1290931972-2770-3-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 11:28 ` Jeff Layton
2010-11-29 7:35 ` Christoph Hellwig [this message]
[not found] ` <20101129073555.GA4573-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2010-11-29 10:41 ` Pavel Shilovsky
[not found] ` <AANLkTimcVhP10LSn5+F+AY+ppnrhKmp_VCsjkKf04cQr-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-29 11:34 ` Pavel Shilovsky
2010-11-29 11:56 ` Jeff Layton
2010-11-28 8:12 ` [PATCH 3/6] CIFS: Make write " Pavel Shilovsky
[not found] ` <1290931972-2770-4-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 11:36 ` Jeff Layton
[not found] ` <20101128063604.7d9cdded-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-11-28 11:51 ` Jeff Layton
[not found] ` <20101128065100.51c8a404-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-11-29 10:58 ` Pavel Shilovsky
[not found] ` <AANLkTimO9t_wXPZRWXx856-wkG-EwRWTizrCKSo4e2SY-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-29 11:37 ` Jeff Layton
[not found] ` <20101129063713.0b71ac09-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-11-29 11:55 ` Pavel Shilovsky
2010-11-29 12:13 ` Suresh Jayaraman
[not found] ` <4CF39901.3010108-l3A5Bk7waGM@public.gmane.org>
2010-11-29 12:16 ` Pavel Shilovsky
2010-11-29 12:26 ` Pavel Shilovsky
[not found] ` <AANLkTimvA08MT5gcy=h_w6UtcTgyvos4X4x+KUTVbM8u-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-29 16:24 ` Suresh Jayaraman
[not found] ` <4CF3D3D9.3060500-l3A5Bk7waGM@public.gmane.org>
2010-11-29 17:08 ` Pavel Shilovsky
[not found] ` <AANLkTikB6_nwg+G+pYv9NNeohHPwymjUkv3r-mJkZBxW-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-01 9:46 ` Suresh Jayaraman
[not found] ` <4CF61979.5080505-l3A5Bk7waGM@public.gmane.org>
2010-12-01 16:39 ` Pavel Shilovsky
[not found] ` <AANLkTik1AC5YJV_CtihSobE1mgj1-7tuiBLf7_nDsiv2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-06 11:50 ` Suresh Jayaraman
[not found] ` <4CFCCE17.2010108-l3A5Bk7waGM@public.gmane.org>
2010-12-06 17:55 ` Pavel Shilovsky
2010-11-28 8:12 ` [PATCH 4/6] CIFS: Make cifs_fsync " Pavel Shilovsky
[not found] ` <1290931972-2770-5-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 11:42 ` Jeff Layton
[not found] ` <20101128064219.7ca2274c-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-11-28 11:52 ` Jeff Layton
2010-11-28 8:12 ` [PATCH 5/6] CIFS: Make cifs_file_map " Pavel Shilovsky
2010-11-28 8:12 ` [PATCH 6/6] CIFS: Add strictcache mount option " Pavel Shilovsky
2010-11-29 10:54 ` [PATCH 0/6] Add strict cache mode (try #4) Suresh Jayaraman
[not found] ` <4CF3864E.50901-l3A5Bk7waGM@public.gmane.org>
2010-11-29 11:00 ` Pavel Shilovsky
[not found] ` <AANLkTinLbS7V=Ok_Eje=mnrBOkZEJJo9iQ9SYwHsbsag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-29 12:15 ` Suresh Jayaraman
[not found] ` <4CF3995C.4080709-l3A5Bk7waGM@public.gmane.org>
2010-11-29 12:22 ` Pavel Shilovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129073555.GA4573@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox