Re: [PATCH -v3] cifs: add attribute cache timeout (actimeo) tunable

[Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Tue, 30 Nov 2010 22:41:06 +0530
Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org> wrote:

> >> +/*
> >>   * MAX_REQ is the maximum number of requests that WE will send
> >>   * on one socket concurrently. It also matches the most common
> >>   * value of max multiplex returned by servers.  We may
> >> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> >> index 32fa4d9..ee7cb11 100644
> >> --- a/fs/cifs/connect.c
> >> +++ b/fs/cifs/connect.c
> >> @@ -105,6 +105,7 @@ struct smb_vol {
> >>  	unsigned int wsize;
> >>  	bool sockopt_tcp_nodelay:1;
> >>  	unsigned short int port;
> >> +	unsigned long actimeo; /* attribute cache timeout (jiffies) */
> > 
> > 	^^^ unused variable?
> 
> We use this to store the actimeo value in jiffies as we parse the mount
> options in cifs_parse_mount_options() below in this patch.
> 
> Did you mean this could be avoided?
> 

Sorry, I misread the patch and thought it was a local variable in
cifs_parse_mount_options. Please disregard that comment.

-- 
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>