Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Wayne Walker <wwalker-7+hyfkrzchDWTcdHvfGLfFaTQe2KTcn/@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: UNS: Re: Data corruption problem
Date: Fri, 11 Feb 2011 09:00:51 -0600	[thread overview]
Message-ID: <20110211150051.GL27051@solid-constructs.com> (raw)
In-Reply-To: <20110211094117.1f012cae-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>

On Fri, Feb 11, 2011 at 09:41:17AM -0500, Jeff Layton wrote:
> > No, Jeff.  Nothing in the logs and from the user space side there are
> > no errors.  All debug levels are at the system defaults.  After 12
> > attempts last night I've still not reproduced.  I will work with my QA
> > guy this morning (CST here) to see if we can reproduce.  What can I do
> > to gather the best data for you guys?
> > 
> 
> To be clear...are you sure that the close(2) or fsync(2) syscalls did
> not return an error? It's a common bug for programs to ignore the return
> code from close(2), and that's where errors during writeback get
> reported.

Gotcha, I will grab a java dev and code review the test app.  My java-fu
is weak, but I think java will throw an exception on either failure,
just have to make sure some dev didn't put in a wide open catch.

> The reason I ask is that there were some issues that were fixed
> recently in mainline with cifs writeback. The CIFS code treated
> timeouts during writeback as hard errors instead of retrying them, but
> in those cases the client should have returned an error during fsync or
> close.

Good to know.  Thank you.

-- 

Wayne Walker
wwalker-7+hyfkrzchDWTcdHvfGLfFaTQe2KTcn/@public.gmane.org
(512) 633-8076
Senior Consultant
Solid Constructs, LLC

> A: Because it messes up the order in which people normally read text.
> > Q: Why is top-posting such a bad thing?
> > > A: Top-posting.
> > > > Q: What is the most annoying thing in e-mail?

  parent reply	other threads:[~2011-02-11 15:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11  5:14 Data corruption problem Wayne Walker
     [not found] ` <20110211051458.GD27051-7+hyfkrzchDWTcdHvfGLfFaTQe2KTcn/@public.gmane.org>
2011-02-11  5:21   ` Wayne Walker
2011-02-11 11:53   ` Jeff Layton
     [not found]     ` <20110211065318.62f91a5b-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-02-11 14:35       ` Wayne Walker
     [not found]         ` <20110211143520.GI27051-7+hyfkrzchDWTcdHvfGLfFaTQe2KTcn/@public.gmane.org>
2011-02-11 14:41           ` Jeff Layton
     [not found]             ` <20110211094117.1f012cae-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-02-11 15:00               ` Wayne Walker [this message]
2011-02-18 18:30   ` Wayne Walker
     [not found]     ` <20110218183003.GF25484-7+hyfkrzchDWTcdHvfGLfFaTQe2KTcn/@public.gmane.org>
2011-02-18 20:45       ` Jeff Layton
     [not found]         ` <20110218154552.7cf091a8-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-02-18 21:49           ` UNS: " Wayne Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110211150051.GL27051@solid-constructs.com \
    --to=wwalker-7+hyfkrzchdwtcdhvfglffatqe2ktcn/@public.gmane.org \
    --cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox