Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
To: Vinay Sawal <vinaysawal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] FC: cifs: Initialized an uninitialized variable
Date: Tue, 8 Mar 2011 04:26:02 +0000	[thread overview]
Message-ID: <20110308042601.GX22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1299556809-16194-1-git-send-email-vinaysawal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Mon, Mar 07, 2011 at 08:00:09PM -0800, Vinay Sawal wrote:
> Removed a compile time warning by initializing an uninitialized variable.

> -	int rc;
> +	int rc = -EFAULT;

Why is that the right thing to do?  Other than "it made the compiler to
STFU, therefore it is Good(tm)", please.

  parent reply	other threads:[~2011-03-08  4:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08  4:00 [PATCH] FC: cifs: Initialized an uninitialized variable Vinay Sawal
     [not found] ` <1299556809-16194-1-git-send-email-vinaysawal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-03-08  4:26   ` Al Viro [this message]
2011-03-08  4:38     ` Steve French
2011-03-08  4:48       ` Vinay Sawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110308042601.GX22723@ZenIV.linux.org.uk \
    --to=viro-3bdd1+5odreifsdqtta3olvcufugdwfn@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
    --cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=vinaysawal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox