From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] CIFS: Fix sparse error
Date: Thu, 9 Jun 2011 07:11:05 -0400 [thread overview]
Message-ID: <20110609071105.097ebf4b@corrin.poochiereds.net> (raw)
In-Reply-To: <1307609933-5632-2-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Thu, 9 Jun 2011 12:58:53 +0400
Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> cifs_sb_master_tlink was declared as inline, but without a definition.
> Remove the declaration and move the definition up.
>
> Signed-off-by: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> fs/cifs/connect.c | 11 ++++-------
> 1 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 23addcb..76a6670 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2203,7 +2203,10 @@ cifs_put_tlink(struct tcon_link *tlink)
> }
>
> static inline struct tcon_link *
> -cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb);
> +cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb)
> +{
> + return cifs_sb->master_tlink;
> +}
>
> static int
> compare_mount_options(struct super_block *sb, struct cifs_mnt_data *mnt_data)
> @@ -3538,12 +3541,6 @@ out:
> return tcon;
> }
>
> -static inline struct tcon_link *
> -cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb)
> -{
> - return cifs_sb->master_tlink;
> -}
> -
> struct cifs_tcon *
> cifs_sb_master_tcon(struct cifs_sb_info *cifs_sb)
> {
Reviewed-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2011-06-09 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 8:58 [PATCH] CIFS: Simplify cifs_demultiplex_thread Pavel Shilovsky
[not found] ` <1307609933-5632-1-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-09 8:58 ` [PATCH] CIFS: Fix sparse error Pavel Shilovsky
[not found] ` <1307609933-5632-2-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-09 11:11 ` Jeff Layton [this message]
2011-06-09 14:13 ` Steve French
2011-06-09 11:54 ` [PATCH] CIFS: Simplify cifs_demultiplex_thread Jeff Layton
[not found] ` <20110609075411.040bf5d1-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-06-09 12:10 ` Pavel Shilovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609071105.097ebf4b@corrin.poochiereds.net \
--to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox