From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: smb2 work status
Date: Sat, 16 Jul 2011 15:28:11 -0400 [thread overview]
Message-ID: <20110716192811.GE26925@infradead.org> (raw)
In-Reply-To: <CAKywueRiuj=DrumdGMvdWX6ih8PVz4L0BL7G=LNL6CO+cEfmTQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Sat, Jul 16, 2011 at 01:29:22PM +0400, Pavel Shilovsky wrote:
> Jeff, Christoph, can you comment on this, please?
I really don't like all that ifdef mess. I'm not quite sure how to
fix in in general, though. For the inode operations it's fairly simple:
just have a different set for smb2, the only shared code is just the
path_from_dentry call, so there's not much duplication. But for the
rest I'm not too sure. Stubbing things out smarter would help, as
would creating more helpers but I'm not sure that's going to help
with everything. Also some of the big bulk commits earlier in the
series add code that's pretty far from the normal Linux style, e.g.
smb2pdu.c, it would be nice to at least make the new code in cifs
look normal.
next prev parent reply other threads:[~2011-07-16 19:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 6:29 smb2 work status Pavel Shilovsky
[not found] ` <CAKywueQqyi6ynwoAv6Q3GzbxYJSOv7k229N3NA_y05kguqA+DQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-16 9:29 ` Pavel Shilovsky
[not found] ` <CAKywueRiuj=DrumdGMvdWX6ih8PVz4L0BL7G=LNL6CO+cEfmTQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-16 19:28 ` Christoph Hellwig [this message]
[not found] ` <20110716192811.GE26925-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2011-07-18 15:45 ` Pavel Shilovsky
[not found] ` <CAKywueSP7p3pja6FociCPXDtcSuChDdHw1JqCwxyhnqMuP5ahg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-18 15:47 ` Christoph Hellwig
[not found] ` <20110718154730.GA5822-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2011-07-19 11:24 ` Jeff Layton
2011-07-20 14:19 ` Pavel Shilovsky
2011-07-24 14:56 ` Pavel Shilovsky
[not found] ` <CAKywueTDhS_FHtssdVbSrBiPksngYsmotU69u9S1QELnm9Vh+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-26 19:41 ` Pavel Shilovsky
[not found] ` <CAKywueQ2B6R7EzB2t4WDfR15Ot-x823zBzy9nQwRwZSxdpco1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-03 20:20 ` Pavel Shilovsky
-- strict thread matches above, loose matches on Subject: below --
2011-06-02 21:10 Pavel Shilovsky
[not found] ` <BANLkTik5T2aY4V-Kp-AePZYUR+KgKCyNCA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-02 21:17 ` Steve French
[not found] ` <BANLkTi=NEJ2smKXM_irraWnN6gWpzGbTvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-07 18:07 ` Pavel Shilovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110716192811.GE26925@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox