From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 0/4] allow freezing of tasks with netfs calls in flight Date: Tue, 11 Oct 2011 08:18:19 +0200 Message-ID: <20111011061819.GA1377@ucw.cz> References: <1317210761-11518-1-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: trond.myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org, smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, rjw-KKrjLPT3xs0@public.gmane.org, linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, john-D0fwSNaahy58zQARNC3f2A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jeff Layton Return-path: Content-Disposition: inline In-Reply-To: <1317210761-11518-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi! > We've had a number of reports recently of people with NFS and CIFS > mounts that were unable to suspend or hibernate their machines. Here > are a couple of Fedora bugs that illustrate the problem: > > https://bugzilla.redhat.com/show_bug.cgi?id=712088 > https://bugzilla.redhat.com/show_bug.cgi?id=717735 > > When it occurs the problem is pretty clear. We have a task that's > sleeping in the kernel in TASK_KILLABLE sleep, generally waiting > for a reply to come in. Often though, userspace has already taken > down the interface so that reply will never come. The process then > fails to freeze and the suspend fails. Userspace should not take interface down for suspend (*). Why do that? > This patch fixes this by allowing the TASK_KILLABLE sleeps in NFS and > CIFS to be awoken by the freezer and then to try to freeze. If a freeze > event does occur, then the code will treat it as if a schedule() has > already occured. Looks like good idea... (*) unless absolutely neccessary. openvpn? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html