From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [PATCH 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface Date: Tue, 11 Oct 2011 12:41:59 -0400 Message-ID: <20111011124159.47790262@corrin.poochiereds.net> References: <4E946792.1060405@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Steve French , linux-cifs , Alexander Swen To: sjayaraman-l3A5Bk7waGM@public.gmane.org Return-path: In-Reply-To: <4E946792.1060405-l3A5Bk7waGM@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Tue, 11 Oct 2011 21:28:10 +0530 Suresh Jayaraman wrote: > The plan is to deprecate this interface by kernel version 3.4. > > Reported-by: Alexander Swen > Cc: Jeff Layton > Signed-off-by: Suresh Jayaraman > --- > fs/cifs/cifs_debug.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c > index 2fe3cf1..b9c06a8 100644 > --- a/fs/cifs/cifs_debug.c > +++ b/fs/cifs/cifs_debug.c > @@ -526,6 +526,9 @@ static ssize_t cifs_oplock_proc_write(struct file *file, > char c; > int rc; > > + printk(KERN_WARNING "CIFS: The /proc/fs/cifs/OplockEnabled interface " > + "will be removed in kernel version 3.4. Please migrate to " > + "using the 'enable_oplocks' module parameter in cifs.ko."); You probably want a \n at the end of that line. > rc = get_user(c, buffer); > if (rc) > return rc; -- Jeff Layton