Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: "Lars Müller" <lmuelle-IBi9RG/b67k@public.gmane.org>
To: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: uninitialized variables in the 5.4 release
Date: Thu, 19 Apr 2012 19:52:42 +0200	[thread overview]
Message-ID: <20120419175242.GR12994@hip.fritz.box> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 355 bytes --]

Hi,

older gcc versions (4.3 in the case of SUSE Linux Enterprise 11 SP 1 and
SP 2) complain about uninitialized variables in the recent 5.4 release.

The attached patch makes the build process a bit quieter.

Cheers,

Lars
-- 
Lars Müller [ˈlaː(r)z ˈmʏlɐ]
Samba Team + SUSE Labs
SUSE Linux, Maxfeldstraße 5, 90409 Nürnberg, Germany

[-- Attachment #1.2: bku-uid-gid-uninitialized.diff --]
[-- Type: text/x-patch, Size: 615 bytes --]

Author: Lars Mueller <lmuelle-IBi9RG/b67k@public.gmane.org>
Subject: cifs-utils build warns bkupuid and bkupgid may be used uninitialized
Bugzilla: na

Index: cifs-utils-5.4/mount.cifs.c
===================================================================
--- cifs-utils-5.4.orig/mount.cifs.c
+++ cifs-utils-5.4/mount.cifs.c
@@ -863,8 +863,8 @@ parse_options(const char *data, struct p
 	int got_uid = 0;
 	int got_cruid = 0;
 	int got_gid = 0;
-	uid_t uid, cruid = 0, bkupuid;
-	gid_t gid, bkupgid;
+	uid_t uid, cruid = 0, bkupuid = 0;
+	gid_t gid, bkupgid = 0;
 	char *ep;
 	struct passwd *pw;
 	struct group *gr;

[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]

             reply	other threads:[~2012-04-19 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-19 17:52 Lars Müller [this message]
     [not found] ` <20120419175242.GR12994-aSaWmTCphX8QgCKCZH8Z8g@public.gmane.org>
2012-04-19 18:01   ` uninitialized variables in the 5.4 release Jeff Layton
     [not found]     ` <20120419140144.7b435b50-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2012-04-20  5:36       ` Suresh Jayaraman
2012-04-20 15:47   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120419175242.GR12994@hip.fritz.box \
    --to=lmuelle-ibi9rg/b67k@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox