From: David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
samba-technical
<samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org>
Subject: Re: [PATCH] [CIFS] SMB2 FSCTL and IOCTL worker function
Date: Mon, 24 Jun 2013 15:35:57 +0200 [thread overview]
Message-ID: <20130624153557.2b4081ae@f163.suse.de> (raw)
In-Reply-To: <CAH2r5muUxsPGg6VoiykMx-YiT=zyiF5tfgfs6j2U++KoGVCP+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Steve,
On Mon, 24 Jun 2013 02:19:13 -0500
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> + rc = SendReceive2(xid, ses, iov, num_iovecs, &resp_buftype, 0);
> + rsp = (struct smb2_ioctl_rsp *)iov[0].iov_base;
> +
> + if (rc != 0) {
> + if (tcon)
> + cifs_stats_fail_inc(tcon, SMB2_IOCTL_HE);
> + goto ioctl_exit;
> + }
IIUC, this throws away any response data if the server reply status
is unsuccessful.
The caller may wish to obtain the response data under certain error
conditions, particularly in the case of FSCTL_SRV_COPYCHUNK, where the
server returns chunk request limits alongside STATUS_INVALID_PARAMETER
in some cases. See MS-SMB2 2.2.32.1 for details.
Cheers, David
next prev parent reply other threads:[~2013-06-24 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 7:19 [PATCH] [CIFS] SMB2 FSCTL and IOCTL worker function Steve French
[not found] ` <CAH2r5muUxsPGg6VoiykMx-YiT=zyiF5tfgfs6j2U++KoGVCP+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-24 10:24 ` Pavel Shilovsky
2013-06-24 13:35 ` David Disseldorp [this message]
[not found] ` <20130624153557.2b4081ae-c9q3rVCHQSqoYr4blSSd5g@public.gmane.org>
2013-06-25 6:05 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624153557.2b4081ae@f163.suse.de \
--to=ddiss-l3a5bk7wagm@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox