From: David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
samba-technical
<samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org>
Subject: Re: [[PATCH v2] [CIFS] Allow setting per-file compression via SMB2 and SMB3
Date: Wed, 9 Oct 2013 00:25:45 +0200 [thread overview]
Message-ID: <20131009002545.114ae8a5@plati.site> (raw)
In-Reply-To: <CAH2r5mubgNp_gY=0b_dWuQx2X2S1hESz5iKXwNhGZfXwCM7TsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Steve,
On Tue, 8 Oct 2013 15:41:17 -0500
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> + /* Currently only flag we can set is compressed flag */
> + if ((ExtAttrBits & FS_COMPR_FL) == 0)
> + break;
> +
> + /* Try to set compress flag */
> + if (tcon->ses->server->ops->set_compression) {
> + rc = tcon->ses->server->ops->set_compression(
> + xid, tcon, pSMBFile);
> + cifs_dbg(FYI, "set compress flag rc %d\n", rc);
> }
Is the FileFsAttributeInformation known at this stage? If so, you may
wish to check for the FILE_FILE_COMPRESSION capability, and avoid the
request dispatch if absent.
IIRC, Explorer hides the compression check-checkbox if the capability
is missing.
next prev parent reply other threads:[~2013-10-08 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 20:41 [[PATCH v2] [CIFS] Allow setting per-file compression via SMB2 and SMB3 Steve French
[not found] ` <CAH2r5mubgNp_gY=0b_dWuQx2X2S1hESz5iKXwNhGZfXwCM7TsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-08 22:25 ` David Disseldorp [this message]
2013-10-08 22:53 ` Steve French
2013-10-10 6:25 ` Stefan (metze) Metzmacher
[not found] ` <52564845.9040205-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
2013-10-10 13:50 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009002545.114ae8a5@plati.site \
--to=ddiss-l3a5bk7wagm@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox