From: Jeremy Allison <jra-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
samba-technical
<samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org>
Subject: Re: setfacl fix
Date: Fri, 15 Nov 2013 20:55:22 -0800 [thread overview]
Message-ID: <20131116045522.GA4399@jeremy-HP> (raw)
In-Reply-To: <CAH2r5msswZg_NvY9qMNknh2FWht1jMgwW1s2umtaBj3mHreDAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, Nov 15, 2013 at 08:53:12PM -0600, Steve French wrote:
> From: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date: Fri, 15 Nov 2013 20:41:32 -0600
> Subject: [PATCH] [CIFS] setfacl removes part of ACL when setting POSIX ACLs to
> Samba
>
> setfacl over cifs mounts can remove the default ACL when setting the
> (non-default part of) the ACL and vice versa (we were leaving at 0
> rather than setting to -1 the count field for the unaffected
> half of the ACL. For example notice the setfacl removed
> the default ACL in this sequence:
Looks good to me. Removing the default acl when
the number of ACE entries is set to zero is by
design in the Samba server, to allow setfacl -k
to work (remove the default ACL).
Jeremy.
next prev parent reply other threads:[~2013-11-16 4:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 2:53 setfacl fix Steve French
[not found] ` <CAH2r5msswZg_NvY9qMNknh2FWht1jMgwW1s2umtaBj3mHreDAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-16 4:55 ` Jeremy Allison [this message]
2013-11-16 14:55 ` Christoph Hellwig
2013-11-16 15:15 ` steve
[not found] ` <1384614925.3216.6.camel-HkULYb+WTT7YCGPCin2YbQ@public.gmane.org>
2013-11-16 21:55 ` Steve French
[not found] ` <CAH2r5mvHzVXs4zuWZvL8ppBzaXSQHOykwu2Gdky3=ZQ9ZbPZcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-18 8:05 ` AW: " Parzer, Peter
[not found] ` <20131116145507.GA22395-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-11-16 21:38 ` Steve French
[not found] ` <CAH2r5mtXjnAOpKzZzta_yWDGyEPzR7h1wb0UW2pnoicm9Qsgxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-18 15:27 ` Christoph Hellwig
[not found] ` <20131118152723.GA19649-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-11-18 22:44 ` Dave Chinner
2013-11-20 5:19 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131116045522.GA4399@jeremy-HP \
--to=jra-eunubhrolfbytjvyw6ydsg@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox