From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org>
Cc: P??draig Brady <P@draigBrady.com>,
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
samba-technical
<samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org>,
"linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: copy chunk preliminary results
Date: Thu, 21 Nov 2013 03:20:44 -0800 [thread overview]
Message-ID: <20131121112044.GA26664@infradead.org> (raw)
In-Reply-To: <20131121114541.09f67b3f-k1XZOR0ctBLN0uC3ymp8PA@public.gmane.org>
On Thu, Nov 21, 2013 at 11:45:41AM +0100, David Disseldorp wrote:
> It depends on how the SMB server interprets the copy-chunk wire request.
> On Btrfs, Samba can translate the request into a BTRFS_IOC_CLONE_RANGE
> ioctl, in which case the same CoW semantics are observed[1]. See:
>
> https://wiki.samba.org/index.php/Server-Side_Copy#Btrfs_Enhanced_Server-Side_Copy_Offload
>
> By default however, Samba (and Windows) will perform the copy on the
> server-side using regular reads/writes. A generic cp --offload or
> similar would probably make more sense on the client side.
I don't think it really matters what the optimal case is, it matters
what the worst case is. Think about it - a reflink really just is
a smart shortcut for copy + dedup, which a filesystem on the server
could do anyway.
On the other hand a user of cp --reflink expects it to be a quick
operation.
So it's time folks finally get the damn copyfile system call in, use
that for CIFS, NFS and co, as well as letting btrfs optimize it.
next prev parent reply other threads:[~2013-11-21 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 6:30 copy chunk preliminary results Steve French
[not found] ` <CAH2r5mtoGCn-z_-Aetwaxxvn8bS19mexb7Rur3TE=RGipGCppQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-04 10:07 ` Pádraig Brady
[not found] ` <527771DA.1050701-V8g9lnOeT5ydJdNcDFJN0w@public.gmane.org>
2013-11-21 10:45 ` David Disseldorp
[not found] ` <20131121114541.09f67b3f-k1XZOR0ctBLN0uC3ymp8PA@public.gmane.org>
2013-11-21 11:20 ` Christoph Hellwig [this message]
[not found] ` <20131121112044.GA26664-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-11-21 11:35 ` Volker Lendecke
2013-11-21 12:31 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121112044.GA26664@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=P@draigBrady.com \
--cc=ddiss-l3A5Bk7waGM@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox