From: Taesoo Kim <taesoo-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org>
To: Scott Lovenberg
<scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Taesoo Kim <tsgatesv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org"
<sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
linux-cifs <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
changwoo-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org,
sanidhya-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org,
blee-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org,
csong84-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org
Subject: Re: [PATCH 1/1] cifs: potential memory leaks when parsing mnt opts
Date: Sat, 21 Mar 2015 23:23:40 -0400 [thread overview]
Message-ID: <20150322032340.GD5170@taesoo.org> (raw)
In-Reply-To: <CAFB9KM3==40uUXxxOD_CD09zFPj3Fmr-Brt7x4SZj86NTf3_vg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 03/21/15 at 09:10pm, Scott Lovenberg wrote:
> On Sat, Mar 21, 2015 at 6:08 PM, Taesoo Kim <tsgatesv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> > Althouhg mkfs.cifs in userspace performs a bit of sanitization
> > (e.g., forcing one user option), current implementation is not
> > robust. Other options such as iocharset and domainanme are similary
> > vulnerable.
> >
>
> I assume you mean mount.cifs? :-) Anyways, good catch.
Right. FYI, I've tried mangling password field (e.g., pass=a,user=A
&c); Skimming through the code (just a few minutes), there are a few
potential places that don't sanitize its string, unlike passwd. But
don't have much time to play with for now :)
Thanks,
Taesoo
> --
> Peace and Blessings,
> -Scott.
next prev parent reply other threads:[~2015-03-22 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 23:08 [PATCH 1/1] cifs: potential memory leaks when parsing mnt opts Taesoo Kim
[not found] ` <1426979310-31201-1-git-send-email-tsgatesv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-22 2:10 ` Scott Lovenberg
[not found] ` <CAFB9KM3==40uUXxxOD_CD09zFPj3Fmr-Brt7x4SZj86NTf3_vg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-22 3:23 ` Taesoo Kim [this message]
[not found] ` <20150322032340.GD5170-Q1ymHw66ZoYdnm+yROfE0A@public.gmane.org>
2015-03-22 3:54 ` Scott Lovenberg
2015-03-24 4:43 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150322032340.GD5170@taesoo.org \
--to=taesoo-/4nojb3qbvq3upmlikxrzw@public.gmane.org \
--cc=blee-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org \
--cc=changwoo-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org \
--cc=csong84-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=sanidhya-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org \
--cc=scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=tsgatesv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox