From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: Send durable handle v2 contexts when use of persistent handles required
Date: Tue, 3 Nov 2015 14:47:29 +0300 [thread overview]
Message-ID: <20151103114729.GA18287@mwanda> (raw)
Hello Steve French,
The patch ea81d9ba9d72: "Send durable handle v2 contexts when use of
persistent handles required" from Oct 3, 2015, leads to the following
static checker warning:
fs/cifs/smb2pdu.c:1156 create_durable_v2_buf()
warn: struct type mismatch 'create_durable_v2 vs create_durable'
fs/cifs/smb2pdu.c
1151 static struct create_durable_v2 *
1152 create_durable_v2_buf(struct cifs_fid *pfid)
1153 {
1154 struct create_durable_v2 *buf;
1155
1156 buf = kzalloc(sizeof(struct create_durable), GFP_KERNEL);
I think this is a problem, isn't create_durable_v2 larger? Smatch is
bad at calculating the sizes of enums.
1157 if (!buf)
1158 return NULL;
1159
regards,
dan carpenter
next reply other threads:[~2015-11-03 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 11:47 Dan Carpenter [this message]
2015-11-03 15:56 ` Send durable handle v2 contexts when use of persistent handles required Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103114729.GA18287@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox