[PATCH 0/3] cifs: Better dependencies

[PATCH 0/3] cifs: Better dependencies

[Jean Delvare]

Hi all,

This is my attempt to fix and improve the dependencies of cifs.

[PATCH 1/3] cifs: Simplify SMB2 and SMB311 dependencies
[PATCH 2/3] cifs: Only select the required crypto modules
[PATCH 3/3] cifs: Add soft dependencies

I already sent this patch series one year ago, but did not get any
reply, so I am trying again.

Thanks,
-- 
Jean Delvare
SUSE L3 Support

[PATCH 1/3] cifs: Simplify SMB2 and SMB311 dependencies

[Jean Delvare]

* CIFS_SMB2 depends on CIFS, which depends on INET and selects NLS. So
  these dependencies do not need to be repeated for CIFS_SMB2.
* CIFS_SMB311 depends on CIFS_SMB2, which depends on INET. So this
  dependency doesn't need to be repeated for CIFS_SMB311.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Steve French <sfrench@samba.org>
---
 fs/cifs/Kconfig |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- linux-4.5-rc0.orig/fs/cifs/Kconfig	2016-01-11 00:01:32.000000000 +0100
+++ linux-4.5-rc0/fs/cifs/Kconfig	2016-01-22 09:48:02.217561471 +0100
@@ -169,8 +169,7 @@ config CIFS_NFSD_EXPORT
 
 config CIFS_SMB2
 	bool "SMB2 and SMB3 network file system support"
-	depends on CIFS && INET
-	select NLS
+	depends on CIFS
 	select KEYS
 	select FSCACHE
 	select DNS_RESOLVER
@@ -194,7 +193,7 @@ config CIFS_SMB2
 
 config CIFS_SMB311
 	bool "SMB3.1.1 network file system support (Experimental)"
-	depends on CIFS_SMB2 && INET
+	depends on CIFS_SMB2
 
 	help
 	  This enables experimental support for the newest, SMB3.1.1, dialect.


-- 
Jean Delvare
SUSE L3 Support

[PATCH 2/3] cifs: Only select the required crypto modules

[Jean Delvare]

The sha256 and cmac crypto modules are only needed for SMB2+, so move
the select statements to config CIFS_SMB2. Also select CRYPTO_AES
there as SMB2+ needs it.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Steve French <sfrench@samba.org>
---
 fs/cifs/Kconfig |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- linux-4.5-rc0.orig/fs/cifs/Kconfig	2016-01-22 09:52:13.700961277 +0100
+++ linux-4.5-rc0/fs/cifs/Kconfig	2016-01-22 09:56:23.420279765 +0100
@@ -9,8 +9,6 @@ config CIFS
 	select CRYPTO_ARC4
 	select CRYPTO_ECB
 	select CRYPTO_DES
-	select CRYPTO_SHA256
-	select CRYPTO_CMAC
 	help
 	  This is the client VFS module for the Common Internet File System
 	  (CIFS) protocol which is the successor to the Server Message Block
@@ -173,6 +171,9 @@ config CIFS_SMB2
 	select KEYS
 	select FSCACHE
 	select DNS_RESOLVER
+	select CRYPTO_AES
+	select CRYPTO_SHA256
+	select CRYPTO_CMAC
 
 	help
 	  This enables support for the Server Message Block version 2

-- 
Jean Delvare
SUSE L3 Support

[PATCH 3/3] cifs: Add soft dependencies

[Jean Delvare]

List soft dependencies of cifs so that mkinitrd and dracut can include
the required helper modules.

Signed-off-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
---
 fs/cifs/cifsfs.c |   12 ++++++++++++
 1 file changed, 12 insertions(+)

--- linux-4.10-rc5.orig/fs/cifs/cifsfs.c	2017-01-16 11:13:06.974673377 +0100
+++ linux-4.10-rc5/fs/cifs/cifsfs.c	2017-01-25 14:57:06.724389810 +0100
@@ -1365,5 +1365,17 @@ MODULE_DESCRIPTION
     ("VFS to access servers complying with the SNIA CIFS Specification "
      "e.g. Samba and Windows");
 MODULE_VERSION(CIFS_VERSION);
+MODULE_SOFTDEP("pre: arc4");
+MODULE_SOFTDEP("pre: des");
+MODULE_SOFTDEP("pre: ecb");
+MODULE_SOFTDEP("pre: hmac");
+MODULE_SOFTDEP("pre: md4");
+MODULE_SOFTDEP("pre: md5");
+MODULE_SOFTDEP("pre: nls");
+#ifdef CONFIG_CIFS_SMB2
+MODULE_SOFTDEP("pre: aes");
+MODULE_SOFTDEP("pre: cmac");
+MODULE_SOFTDEP("pre: sha256");
+#endif /* CONFIG_CIFS_SMB2 */
 module_init(init_cifs)
 module_exit(exit_cifs)

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH 0/3] cifs: Better dependencies

[Pavel Shilovsky]

2017-01-25 7:06 GMT-08:00 Jean Delvare <jdelvare@suse.de>:
> Hi all,
>
> This is my attempt to fix and improve the dependencies of cifs.
>
> [PATCH 1/3] cifs: Simplify SMB2 and SMB311 dependencies
> [PATCH 2/3] cifs: Only select the required crypto modules
> [PATCH 3/3] cifs: Add soft dependencies
>
> I already sent this patch series one year ago, but did not get any
> reply, so I am trying again.
>
> Thanks,
> --
> Jean Delvare
> SUSE L3 Support
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Looks good.

Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>

-- 
Best regards,
Pavel Shilovsky

Re: [PATCH 0/3] cifs: Better dependencies

[Steve French]

Merged into cifs-2.6.git for-next

Thanks - this is helpful



On Wed, Jan 25, 2017 at 1:26 PM, Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 2017-01-25 7:06 GMT-08:00 Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>:
>> Hi all,
>>
>> This is my attempt to fix and improve the dependencies of cifs.
>>
>> [PATCH 1/3] cifs: Simplify SMB2 and SMB311 dependencies
>> [PATCH 2/3] cifs: Only select the required crypto modules
>> [PATCH 3/3] cifs: Add soft dependencies
>>
>> I already sent this patch series one year ago, but did not get any
>> reply, so I am trying again.
>>
>> Thanks,
>> --
>> Jean Delvare
>> SUSE L3 Support
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> Looks good.
>
> Reviewed-by: Pavel Shilovsky <pshilov-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
>
> --
> Best regards,
> Pavel Shilovsky
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve

[PATCH 0/3] cifs: Better dependencies

[Jean Delvare]

Hi all,

This is my attempt to fix and improve the dependencies of cifs.

[PATCH 1/3] cifs: Simplify SMB2 and SMB311 dependencies
[PATCH 2/3] cifs: Only select the required crypto modules
[PATCH 3/3] cifs: Add soft dependencies

-- 
Jean Delvare
SUSE L3 Support