Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Long Li <longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>
Cc: kbuild-all-JC7UmRfGjtg@public.gmane.org,
	Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Tom Talpey <ttalpey-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
	Matthew Wilcox <mawilcox-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
	Long Li <longli-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
Subject: Re: [Patch v4 14/22] CIFS: SMBD: Implement function to send data via RDMA send
Date: Wed, 4 Oct 2017 17:43:42 +0800	[thread overview]
Message-ID: <201710041734.eqq5RTTm%fengguang.wu@intel.com> (raw)
In-Reply-To: <20171002023030.3582-15-longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 7922 bytes --]

Hi Long,

[auto build test WARNING on cifs/for-next]
[also build test WARNING on v4.14-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Long-Li/CIFS-Implement-SMBDirect/20171004-165915
base:   git://git.samba.org/sfrench/cifs-2.6.git for-next
config: i386-randconfig-x001-201740 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:13:0,
                    from include/linux/list.h:8,
                    from include/linux/module.h:9,
                    from fs/cifs/smbdirect.c:16:
   fs/cifs/smbdirect.c: In function 'smbd_send':
>> fs/cifs/cifs_debug.h:55:24: warning: format '%lu' expects argument of type 'long unsigned int', but argument 8 has type 'size_t {aka unsigned int}' [-Wformat=]
      pr_debug_ratelimited("%s: "    \
                           ^
   include/linux/printk.h:285:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
>> fs/cifs/cifs_debug.h:55:3: note: in expansion of macro 'pr_debug_ratelimited'
      pr_debug_ratelimited("%s: "    \
      ^~~~~~~~~~~~~~~~~~~~
>> fs/cifs/smbdirect.c:143:3: note: in expansion of macro 'cifs_dbg'
      cifs_dbg(VFS, "%s:%d " fmt, __func__, __LINE__, ##args);\
      ^~~~~~~~
>> fs/cifs/smbdirect.c:151:40: note: in expansion of macro 'log_rdma'
    #define log_write(level, fmt, args...) log_rdma(level, LOG_WRITE, fmt, ##args)
                                           ^~~~~~~~
>> fs/cifs/smbdirect.c:2148:6: note: in expansion of macro 'log_write'
         log_write(INFO,
         ^~~~~~~~~
   In file included from fs/cifs/smbdirect.c:18:0:
>> fs/cifs/smbdirect.c:143:17: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'size_t {aka unsigned int}' [-Wformat=]
      cifs_dbg(VFS, "%s:%d " fmt, __func__, __LINE__, ##args);\
                    ^
   fs/cifs/cifs_debug.h:58:16: note: in definition of macro 'cifs_dbg'
      cifs_vfs_err(fmt, ##__VA_ARGS__);   \
                   ^~~
>> fs/cifs/smbdirect.c:151:40: note: in expansion of macro 'log_rdma'
    #define log_write(level, fmt, args...) log_rdma(level, LOG_WRITE, fmt, ##args)
                                           ^~~~~~~~
>> fs/cifs/smbdirect.c:2148:6: note: in expansion of macro 'log_write'
         log_write(INFO,
         ^~~~~~~~~
   In file included from include/linux/kernel.h:13:0,
                    from include/linux/list.h:8,
                    from include/linux/module.h:9,
                    from fs/cifs/smbdirect.c:16:
   fs/cifs/smbdirect.c:143:17: warning: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'size_t {aka unsigned int}' [-Wformat=]
      cifs_dbg(VFS, "%s:%d " fmt, __func__, __LINE__, ##args);\
                    ^
   include/linux/printk.h:285:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   fs/cifs/cifs_debug.h:60:3: note: in expansion of macro 'pr_debug_ratelimited'
      pr_debug_ratelimited(fmt, ##__VA_ARGS__);  \
      ^~~~~~~~~~~~~~~~~~~~
>> fs/cifs/smbdirect.c:143:3: note: in expansion of macro 'cifs_dbg'
      cifs_dbg(VFS, "%s:%d " fmt, __func__, __LINE__, ##args);\
      ^~~~~~~~
>> fs/cifs/smbdirect.c:151:40: note: in expansion of macro 'log_rdma'
    #define log_write(level, fmt, args...) log_rdma(level, LOG_WRITE, fmt, ##args)
                                           ^~~~~~~~
>> fs/cifs/smbdirect.c:2148:6: note: in expansion of macro 'log_write'
         log_write(INFO,
         ^~~~~~~~~

vim +/cifs_dbg +143 fs/cifs/smbdirect.c

056f27d3 Long Li 2017-10-01  112  
056f27d3 Long Li 2017-10-01  113  /* Transport logging functions
056f27d3 Long Li 2017-10-01  114   * Logging are defined as classes. They can be OR'ed to define the actual
056f27d3 Long Li 2017-10-01  115   * logging level via module parameter smbd_logging_class
056f27d3 Long Li 2017-10-01  116   * e.g. cifs.smbd_logging_class=0x500 will log all log_rdma_recv() and
056f27d3 Long Li 2017-10-01  117   * log_rdma_event()
056f27d3 Long Li 2017-10-01  118   */
056f27d3 Long Li 2017-10-01  119  #define LOG_OUTGOING			0x1
056f27d3 Long Li 2017-10-01  120  #define LOG_INCOMING			0x2
056f27d3 Long Li 2017-10-01  121  #define LOG_READ			0x4
056f27d3 Long Li 2017-10-01  122  #define LOG_WRITE			0x8
056f27d3 Long Li 2017-10-01  123  #define LOG_RDMA_SEND			0x10
056f27d3 Long Li 2017-10-01  124  #define LOG_RDMA_RECV			0x20
056f27d3 Long Li 2017-10-01  125  #define LOG_KEEP_ALIVE			0x40
056f27d3 Long Li 2017-10-01  126  #define LOG_RDMA_EVENT			0x80
056f27d3 Long Li 2017-10-01  127  #define LOG_RDMA_MR			0x100
056f27d3 Long Li 2017-10-01  128  static unsigned int smbd_logging_class = 0;
056f27d3 Long Li 2017-10-01  129  module_param(smbd_logging_class, uint, 0644);
056f27d3 Long Li 2017-10-01  130  MODULE_PARM_DESC(smbd_logging_class,
056f27d3 Long Li 2017-10-01  131  	"Logging class for SMBD transport 0x0 to 0x100");
056f27d3 Long Li 2017-10-01  132  
056f27d3 Long Li 2017-10-01  133  #define ERR		0x0
056f27d3 Long Li 2017-10-01  134  #define INFO		0x1
056f27d3 Long Li 2017-10-01  135  static unsigned int smbd_logging_level = ERR;
056f27d3 Long Li 2017-10-01  136  module_param(smbd_logging_level, uint, 0644);
056f27d3 Long Li 2017-10-01  137  MODULE_PARM_DESC(smbd_logging_level,
056f27d3 Long Li 2017-10-01  138  	"Logging level for SMBD transport, 0 (default): error, 1: info");
056f27d3 Long Li 2017-10-01  139  
056f27d3 Long Li 2017-10-01  140  #define log_rdma(level, class, fmt, args...)				\
056f27d3 Long Li 2017-10-01  141  do {									\
056f27d3 Long Li 2017-10-01  142  	if (level <= smbd_logging_level || class & smbd_logging_class)	\
056f27d3 Long Li 2017-10-01 @143  		cifs_dbg(VFS, "%s:%d " fmt, __func__, __LINE__, ##args);\
056f27d3 Long Li 2017-10-01  144  } while (0)
056f27d3 Long Li 2017-10-01  145  
056f27d3 Long Li 2017-10-01  146  #define log_outgoing(level, fmt, args...) \
056f27d3 Long Li 2017-10-01  147  		log_rdma(level, LOG_OUTGOING, fmt, ##args)
056f27d3 Long Li 2017-10-01  148  #define log_incoming(level, fmt, args...) \
056f27d3 Long Li 2017-10-01  149  		log_rdma(level, LOG_INCOMING, fmt, ##args)
056f27d3 Long Li 2017-10-01  150  #define log_read(level, fmt, args...)	log_rdma(level, LOG_READ, fmt, ##args)
056f27d3 Long Li 2017-10-01 @151  #define log_write(level, fmt, args...)	log_rdma(level, LOG_WRITE, fmt, ##args)
056f27d3 Long Li 2017-10-01  152  #define log_rdma_send(level, fmt, args...) \
056f27d3 Long Li 2017-10-01  153  		log_rdma(level, LOG_RDMA_SEND, fmt, ##args)
056f27d3 Long Li 2017-10-01  154  #define log_rdma_recv(level, fmt, args...) \
056f27d3 Long Li 2017-10-01  155  		log_rdma(level, LOG_RDMA_RECV, fmt, ##args)
056f27d3 Long Li 2017-10-01  156  #define log_keep_alive(level, fmt, args...) \
056f27d3 Long Li 2017-10-01  157  		log_rdma(level, LOG_KEEP_ALIVE, fmt, ##args)
056f27d3 Long Li 2017-10-01  158  #define log_rdma_event(level, fmt, args...) \
056f27d3 Long Li 2017-10-01  159  		log_rdma(level, LOG_RDMA_EVENT, fmt, ##args)
056f27d3 Long Li 2017-10-01  160  #define log_rdma_mr(level, fmt, args...) \
056f27d3 Long Li 2017-10-01  161  		log_rdma(level, LOG_RDMA_MR, fmt, ##args)
056f27d3 Long Li 2017-10-01  162  

:::::: The code at line 143 was first introduced by commit
:::::: 056f27d3b5a46aa10b0e23437c46d1c5a9fab431 CIFS: SMBD: Establish SMBDirect connection

:::::: TO: Long Li <longli-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
:::::: CC: 0day robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34831 bytes --]

  parent reply	other threads:[~2017-10-04  9:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-02  2:30 [Patch v4 00/22] CIFS: Implement SMBDirect Long Li
2017-10-02  2:30 ` [Patch v4 01/22] CIFS: SMBD: Add SMBDirect protocol initial values and constants Long Li
2017-10-02  2:30 ` [Patch v4 02/22] CIFS: SMBD: Establish SMBDirect connection Long Li
     [not found]   ` <20171002023030.3582-3-longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>
2017-10-04 11:01     ` kbuild test robot
2017-10-02  2:30 ` [Patch v4 03/22] CIFS: SMBD: export protocol initial values Long Li
2017-10-02  2:30 ` [Patch v4 04/22] CIFS: SMBD: Add rdma mount option Long Li
2017-10-02  2:30 ` [Patch v4 08/22] CIFS: SMBD: Upper layer reconnects to SMBDirect session Long Li
2017-10-02  2:30 ` [Patch v4 09/22] CIFS: SMBD: Implement function to destroy a SMBDirect connection Long Li
     [not found] ` <20171002023030.3582-1-longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>
2017-10-02  2:30   ` [Patch v4 05/22] CIFS: SMBD: Implement function to create " Long Li
2017-10-02  2:30   ` [Patch v4 06/22] CIFS: SMBD: Upper layer connects to SMBDirect session Long Li
2017-10-02  2:30   ` [Patch v4 07/22] CIFS: SMBD: Implement function to reconnect to a SMBDirect transport Long Li
2017-10-02  2:30   ` [Patch v4 10/22] CIFS: SMBD: Upper layer destroys SMBDirect session on shutdown or umount Long Li
2017-10-02  2:30   ` [Patch v4 13/22] CIFS: SMBD: Upper layer receives data via RDMA receive Long Li
2017-10-02  2:30   ` [Patch v4 18/22] CIFS: SMBD: Upper layer performs SMB write via RDMA read through memory registration Long Li
2017-10-02  2:30   ` [Patch v4 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write " Long Li
2017-10-02  2:30 ` [Patch v4 11/22] CIFS: SMBD: Set SMBDirect maximum read or write size for I/O Long Li
2017-10-02  2:30 ` [Patch v4 12/22] CIFS: SMBD: Implement function to receive data via RDMA receive Long Li
     [not found]   ` <20171002023030.3582-13-longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>
2017-10-04  9:43     ` kbuild test robot
2017-10-02  2:30 ` [Patch v4 14/22] CIFS: SMBD: Implement function to send data via RDMA send Long Li
     [not found]   ` <20171002023030.3582-15-longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>
2017-10-04  9:43     ` kbuild test robot [this message]
2017-10-04 10:05     ` kbuild test robot
2017-10-02  2:30 ` [Patch v4 15/22] CIFS: SMBD: Upper layer sends " Long Li
2017-10-02  2:30 ` [Patch v4 16/22] CIFS: SMBD: Fix the definition for SMB2_CHANNEL_RDMA_V1_INVALIDATE Long Li
     [not found]   ` <20171002023030.3582-17-longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>
2017-10-04 22:07     ` Steve French
2017-10-02  2:30 ` [Patch v4 17/22] CIFS: SMBD: Implement RDMA memory registration Long Li
2017-10-04 14:08   ` kbuild test robot
2017-10-02  2:30 ` [Patch v4 19/22] CIFS: SMBD: Add parameter rdata to smb2_new_read_req Long Li
2017-10-02  2:30 ` [Patch v4 20/22] CIFS: SMBD: Read correct returned data length for RDMA write (SMB read) I/O Long Li
2017-10-02  2:30 ` [Patch v4 22/22] CIFS: SMBD: Add SMBDirect debug counters Long Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201710041734.eqq5RTTm%fengguang.wu@intel.com \
    --to=lkp-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=kbuild-all-JC7UmRfGjtg@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=longli-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
    --cc=longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org \
    --cc=mawilcox-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
    --cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
    --cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=ttalpey-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox