From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 01/19] cifs: Add SendReceive3 Date: Fri, 3 Nov 2017 06:36:26 -0700 Message-ID: <20171103133626.GA4280@infradead.org> References: <20171102070312.18903-1-lsahlber@redhat.com> <20171102070312.18903-2-lsahlber@redhat.com> <20171103062715.GB8075@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Ronnie Sahlberg , linux-cifs , Steve French To: ronnie sahlberg Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Fri, Nov 03, 2017 at 04:37:59PM +1000, ronnie sahlberg wrote: > Since this will now be the _only_ send/receive function SMB2 uses > (except for the two async calls) > I can rename it s/SendReceive3/SMB2SendReceive/ ? smb2_send_recv, please. > > Also please explain the strategy for phasing out the old API(s) so > > that we won't have three around forever. > > That is harder and I don't plan to do so. > SendReceive2 and SendReceiveNoRsp is after this series no longer used by > smb2, but they are still used by SMB1. > SMB1 uses a LOT of different send/receive functions. > > > I don't want to touch SMB1. I mostly want it to just go away :-) Oh well. I guess it's just going to slowly bitrot then..