From: Long Li <longli@exchange.microsoft.com>
To: Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Tom Talpey <ttalpey@microsoft.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Cc: Long Li <longli@microsoft.com>
Subject: [Patch v8 16/16] CIFS: SMBD: Disable signing on SMB direct transport
Date: Wed, 22 Nov 2017 17:38:49 -0700 [thread overview]
Message-ID: <20171123003849.17093-17-longli@exchange.microsoft.com> (raw)
In-Reply-To: <20171123003849.17093-1-longli@exchange.microsoft.com>
From: Long Li <longli@microsoft.com>
Currently the CIFS SMB Direct implementation (experimental) doesn't properly
support signing. Disable it when SMB Direct is in use for transport.
Signing will be enabled in future after it is implemented.
Signed-off-by: Long Li <longli@microsoft.com>
---
fs/cifs/connect.c | 8 ++++++++
fs/cifs/smb2pdu.c | 5 +++++
2 files changed, 13 insertions(+)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 1677401..b18eae1 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1968,6 +1968,14 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
goto cifs_parse_mount_err;
}
+#ifdef CONFIG_CIFS_SMB_DIRECT
+ if (vol->rdma && vol->sign) {
+ cifs_dbg(VFS, "Currently SMB direct doesn't support signing."
+ " This is being fixed\n");
+ goto cifs_parse_mount_err;
+ }
+#endif
+
#ifndef CONFIG_KEYS
/* Muliuser mounts require CONFIG_KEYS support */
if (vol->multiuser) {
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index bee0871d..a3e67be 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -616,6 +616,11 @@ int smb3_validate_negotiate(const unsigned int xid, struct cifs_tcon *tcon)
cifs_dbg(FYI, "validate negotiate\n");
+#ifdef CONFIG_CIFS_SMB_DIRECT
+ if (tcon->ses->server->rdma)
+ return 0;
+#endif
+
/*
* validation ioctl must be signed, so no point sending this if we
* can not sign it (ie are not known user). Even if signing is not
--
2.7.4
next prev parent reply other threads:[~2017-11-23 0:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 0:38 [Patch v8 00/16] CIFS: Implement SMB Direct protocol Long Li
2017-11-23 0:38 ` [Patch v8 01/16] CIFS: SMBD: Upper layer connects to SMBDirect session Long Li
2017-11-23 0:38 ` [Patch v8 02/16] CIFS: SMBD: Implement function to reconnect to a SMB Direct transport Long Li
[not found] ` <20171123003849.17093-3-longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>
2018-01-03 17:51 ` Steve French
2017-11-23 0:38 ` [Patch v8 04/16] CIFS: SMBD: Implement function to destroy a SMB Direct connection Long Li
2017-11-23 0:38 ` [Patch v8 06/16] CIFS: SMBD: Set SMB Direct maximum read or write size for I/O Long Li
2017-11-23 0:38 ` [Patch v8 07/16] CIFS: SMBD: Implement function to receive data via RDMA receive Long Li
2017-11-23 0:38 ` [Patch v8 08/16] CIFS: SMBD: Upper layer receives " Long Li
2017-11-23 0:38 ` [Patch v8 10/16] CIFS: SMBD: Upper layer sends data via RDMA send Long Li
2017-11-23 0:38 ` [Patch v8 11/16] CIFS: SMBD: Implement RDMA memory registration Long Li
2017-11-23 0:38 ` [Patch v8 13/16] CIFS: SMBD: Read correct returned data length for RDMA write (SMB read) I/O Long Li
2017-11-23 0:38 ` [Patch v8 14/16] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration Long Li
[not found] ` <20171123003849.17093-15-longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>
2018-01-03 21:31 ` Steve French
2017-11-23 0:38 ` [Patch v8 15/16] CIFS: SMBD: Add SMB Direct debug counters Long Li
2017-11-23 0:38 ` Long Li [this message]
2017-12-28 21:57 ` [Patch v8 00/16] CIFS: Implement SMB Direct protocol Pavel Shilovskiy
[not found] ` <20171123003849.17093-1-longli-Lp/cVzEoVyZiJJESP9tAQJZ3qXmFLfmx@public.gmane.org>
2017-11-23 0:38 ` [Patch v8 03/16] CIFS: SMBD: Upper layer reconnects to SMB Direct session Long Li
2017-11-23 0:38 ` [Patch v8 05/16] CIFS: SMBD: Upper layer destroys SMB Direct session on shutdown or umount Long Li
2017-11-23 0:38 ` [Patch v8 09/16] CIFS: SMBD: Implement function to send data via RDMA send Long Li
2017-11-23 0:38 ` [Patch v8 12/16] CIFS: SMBD: Upper layer performs SMB write via RDMA read through memory registration Long Li
2018-01-01 23:28 ` [Patch v8 00/16] CIFS: Implement SMB Direct protocol Ronnie Sahlberg
2018-01-03 21:39 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123003849.17093-17-longli@exchange.microsoft.com \
--to=longli@exchange.microsoft.com \
--cc=hch@infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mawilcox@microsoft.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sthemmin@microsoft.com \
--cc=ttalpey@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox