From: Long Li <longli@linuxonhyperv.com>
To: Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Cc: Long Li <longli@microsoft.com>
Subject: [RFC PATCH 02/09] Change wdata alloc to support direct pages
Date: Thu, 17 May 2018 17:22:07 -0700 [thread overview]
Message-ID: <20180518002214.5657-3-longli@linuxonhyperv.com> (raw)
In-Reply-To: <20180518002214.5657-1-longli@linuxonhyperv.com>
From: Long Li <longli@microsoft.com>
When using direct pages from user space, there is no need to allocate pages.
Just ping those user pages for RDMA.
Signed-off-by: Long Li <longli@microsoft.com>
---
fs/cifs/cifsproto.h | 2 +-
fs/cifs/cifssmb.c | 10 +++++++---
fs/cifs/file.c | 4 ++--
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/fs/cifs/cifsproto.h b/fs/cifs/cifsproto.h
index 365a414..94106b9 100644
--- a/fs/cifs/cifsproto.h
+++ b/fs/cifs/cifsproto.h
@@ -523,7 +523,7 @@ int cifs_readv_receive(struct TCP_Server_Info *server, struct mid_q_entry *mid);
int cifs_async_writev(struct cifs_writedata *wdata,
void (*release)(struct kref *kref));
void cifs_writev_complete(struct work_struct *work);
-struct cifs_writedata *cifs_writedata_alloc(unsigned int nr_pages,
+struct cifs_writedata *cifs_writedata_alloc(unsigned int nr_pages, struct page **direct_pages,
work_func_t complete);
void cifs_writedata_release(struct kref *refcount);
int cifs_query_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index 1529a08..3b1731d 100644
--- a/fs/cifs/cifssmb.c
+++ b/fs/cifs/cifssmb.c
@@ -1983,7 +1983,7 @@ cifs_writev_requeue(struct cifs_writedata *wdata)
tailsz = rest_len - (nr_pages - 1) * PAGE_SIZE;
}
- wdata2 = cifs_writedata_alloc(nr_pages, cifs_writev_complete);
+ wdata2 = cifs_writedata_alloc(nr_pages, NULL, cifs_writev_complete);
if (!wdata2) {
rc = -ENOMEM;
break;
@@ -2067,12 +2067,16 @@ cifs_writev_complete(struct work_struct *work)
}
struct cifs_writedata *
-cifs_writedata_alloc(unsigned int nr_pages, work_func_t complete)
+cifs_writedata_alloc(unsigned int nr_pages, struct page **direct_pages, work_func_t complete)
{
struct cifs_writedata *wdata;
/* writedata + number of page pointers */
- wdata = kzalloc(sizeof(*wdata) +
+ if (direct_pages) {
+ wdata = kzalloc(sizeof(*wdata), GFP_NOFS);
+ wdata->direct_pages = direct_pages;
+ } else
+ wdata = kzalloc(sizeof(*wdata) +
sizeof(struct page *) * nr_pages, GFP_NOFS);
if (wdata != NULL) {
kref_init(&wdata->refcount);
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 23fd430..a6ec896 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -1965,7 +1965,7 @@ wdata_alloc_and_fillpages(pgoff_t tofind, struct address_space *mapping,
{
struct cifs_writedata *wdata;
- wdata = cifs_writedata_alloc((unsigned int)tofind,
+ wdata = cifs_writedata_alloc((unsigned int)tofind, NULL,
cifs_writev_complete);
if (!wdata)
return NULL;
@@ -2554,7 +2554,7 @@ cifs_write_from_iter(loff_t offset, size_t len, struct iov_iter *from,
break;
nr_pages = get_numpages(wsize, len, &cur_len);
- wdata = cifs_writedata_alloc(nr_pages,
+ wdata = cifs_writedata_alloc(nr_pages, NULL,
cifs_uncached_writev_complete);
if (!wdata) {
rc = -ENOMEM;
--
2.7.4
next prev parent reply other threads:[~2018-05-18 0:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 0:22 [RFC PATCH 00/09] Implement direct user I/O interfaces for RDMA Long Li
2018-05-17 23:10 ` Tom Talpey
2018-05-18 6:03 ` Long Li
2018-05-18 6:44 ` Christoph Hellwig
2018-05-19 0:58 ` Tom Talpey
2018-05-18 6:42 ` Christoph Hellwig
2018-05-18 0:22 ` [RFC PATCH 01/09] Introduce offset for the 1st page in data transfer structures Long Li
2018-05-18 6:37 ` Steve French
2018-05-18 0:22 ` Long Li [this message]
2018-05-19 1:05 ` [RFC PATCH 02/09] Change wdata alloc to support direct pages Tom Talpey
2018-05-18 0:22 ` [RFC PATCH 03/09] Change rdata " Long Li
2018-05-18 0:22 ` [RFC PATCH 04/09] Change function to support offset when reading pages Long Li
2018-05-18 0:22 ` [RFC PATCH 05/09] Change RDMA send to regonize page offset in the 1st page Long Li
2018-05-19 1:09 ` Tom Talpey
2018-05-19 5:54 ` Long Li
2018-05-18 0:22 ` [RFC PATCH 06/09] Change RDMA recv to support " Long Li
2018-05-18 0:22 ` [RFC PATCH 07/09] Support page offset in memory regsitrations Long Li
2018-05-18 0:22 ` [RFC PATCH 08/09] Implement direct file I/O interfaces Long Li
2018-05-18 0:22 ` [RFC PATCH 09/09] Introduce cache=rdma moutning option Long Li
2018-05-18 7:26 ` Christoph Hellwig
2018-05-18 19:00 ` Long Li
2018-05-18 20:44 ` Steve French
2018-05-18 20:58 ` Long Li
2018-05-19 1:20 ` Tom Talpey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518002214.5657-3-longli@linuxonhyperv.com \
--to=longli@linuxonhyperv.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).