Re: [PATCH 15/25] vfs: plumb RFR_* remap flags through the vfs clone functions

Amir Goldstein
2018-10-10T06:39:44Z

On Wed, Oct 10, 2018 at 9:22 AM Amir Goldstein <amir73il@gmail.com> wrote:
>
> On Wed, Oct 10, 2018 at 3:14 AM Darrick J. Wong <darrick.wong@oracle.com> wrote:
> >
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Plumb a remap_flags argument through the {do,vfs}_clone_file_range
> > functions so that clone can take advantage of it.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> [...]
> > diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
> > index c8c890c22898..8b22035af4d7 100644
> > --- a/fs/overlayfs/file.c
> > +++ b/fs/overlayfs/file.c
> > @@ -462,7 +462,7 @@ static loff_t ovl_copyfile(struct file *file_in, loff_t pos_in,
> >
> > case OVL_CLONE:
> > ret = vfs_clone_file_range(real_in.file, pos_in,
> > - real_out.file, pos_out, len);
> > + real_out.file, pos_out, len, flags);
> > break;
> >
> > case OVL_DEDUPE:
> > @@ -509,7 +509,7 @@ static loff_t ovl_remap_file_range(struct file *file_in, loff_t pos_in,
> > !ovl_inode_upper(file_inode(file_out))))
> > return -EPERM;
> >
> > - return ovl_copyfile(file_in, pos_in, file_out, pos_out, len, 0,
> > + return ovl_copyfile(file_in, pos_in, file_out, pos_out, len, flags,
> > op);
> > }
>
> This patch forgets to change args in ovl_copyfile() function definition.
>

Sorry, it was already there.

Thanks,
Amir.