Re: [PATCH 01/25] xfs: add a per-xfs trace_printk macro

Darrick J. Wong
2018-10-11T23:34:43Z

On Thu, Oct 11, 2018 at 06:39:34AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 10, 2018 at 09:12:23PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Add a "xfs_tprintk" macro so that developers can use trace_printk to
> > print out arbitrary debugging information with the XFS device name
> > attached to the trace output.
>
> I can't say I'm a fan of this. trace_printk is a debugging aid,
> and opencoding the file system name really isn't much of a burden.

<shrug> I got tired enough of typing it to add a ewwgross macro, and then
got tired enough of maintaining the patch, let's see what Dave says. :)

--D