Re: [PATCH v2 03/11] cifs: Register generic netlink family

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2539 bytes --]

Hi Samuel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on cifs/for-next]
[also build test WARNING on linus/master v5.10-rc1 next-20201027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Samuel-Cabrero/Witness-protocol-support-for-transparent-failover/20201027-180948
base:   git://git.samba.org/sfrench/cifs-2.6.git for-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c097d4f8238be23b7a1e036c4b0e1e1c996a303d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Samuel-Cabrero/Witness-protocol-support-for-transparent-failover/20201027-180948
        git checkout c097d4f8238be23b7a1e036c4b0e1e1c996a303d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/cifs/netlink.c:42:5: warning: no previous prototype for 'cifs_genl_init' [-Wmissing-prototypes]
      42 | int cifs_genl_init(void)
         |     ^~~~~~~~~~~~~~
>> fs/cifs/netlink.c:59:6: warning: no previous prototype for 'cifs_genl_exit' [-Wmissing-prototypes]
      59 | void cifs_genl_exit(void)
         |      ^~~~~~~~~~~~~~

vim +/cifs_genl_init +42 fs/cifs/netlink.c

    36	
    37	/**
    38	 * cifs_genl_init - Register generic netlink family
    39	 *
    40	 * Return zero if initialized successfully, otherwise non-zero.
    41	 */
  > 42	int cifs_genl_init(void)
    43	{
    44		int ret;
    45	
    46		ret = genl_register_family(&cifs_genl_family);
    47		if (ret < 0) {
    48			cifs_dbg(VFS, "%s: failed to register netlink family\n",
    49					__func__);
    50			return ret;
    51		}
    52	
    53		return 0;
    54	}
    55	
    56	/**
    57	 * cifs_genl_exit - Unregister generic netlink family
    58	 */
  > 59	void cifs_genl_exit(void)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66072 bytes --]