From: Jeremy Allison <jra@samba.org>
To: Steve French <smfrench@gmail.com>,
Xiaoli Feng <xifeng@redhat.com>,
samba-technical <samba-technical@lists.samba.org>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH][SMB3] allow files to be created with backslash in file name
Date: Sat, 2 Jan 2021 17:25:11 -0800 [thread overview]
Message-ID: <20210103012511.GC117067@jeremy-acer> (raw)
In-Reply-To: <20210103012116.GA117067@jeremy-acer>
On Sat, Jan 02, 2021 at 05:21:16PM -0800, Jeremy Allison via samba-technical wrote:
>On Sat, Jan 02, 2021 at 06:19:39PM -0600, Steve French wrote:
>>I agree with the idea of being safe (in the smbclient in this case),
>>and not returning potentially dangerous file names (even if a very
>>remote danger to the tool, smbclient in this case), but I am not
>>convinced that the "user friendly" behavior is to reject the names
>>with the rather confusing message - especially as it would mean that
>>inserting a single file with an odd name into a server could make the
>>whole share unusable for smbclient (e.g. in a backup scenario). I
FYI, as I pointed out this only happens if you *explicitly*
set a server parameter that is only expected to be set on
a share with "clean" (no non-Windows) names.
So just creating a file containing : \ etc. doesn't do
this - you have to misconfigure the server FIRST.
next prev parent reply other threads:[~2021-01-03 1:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 3:35 [PATCH][SMB3] allow files to be created with backslash in file name Steve French
2021-01-01 6:00 ` Jeremy Allison
[not found] ` <CAH2r5mt+5LQB59w0SPEp2Q-9ZZ2PV=XDMtGpy2pedhF8eKif0A@mail.gmail.com>
2021-01-01 19:58 ` Jeremy Allison
[not found] ` <CAH2r5mvt_cHDbT0xaeLNQn=5cQ0T2-wPgpMkYEGQNdtDZ3kP=A@mail.gmail.com>
2021-01-02 2:58 ` Jeremy Allison
2021-01-02 3:49 ` Steve French
2021-01-02 5:25 ` Jeremy Allison
2021-01-03 0:19 ` Steve French
2021-01-03 1:21 ` Jeremy Allison
2021-01-03 1:25 ` Jeremy Allison [this message]
2021-01-03 3:45 ` Steve French
2021-01-03 4:13 ` Jeremy Allison
2021-01-01 20:06 ` Jeremy Allison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210103012511.GC117067@jeremy-acer \
--to=jra@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
--cc=xifeng@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).