Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@cjr.nz>
To: linux-cifs@vger.kernel.org, smfrench@gmail.com
Cc: Paulo Alcantara <pc@cjr.nz>
Subject: [PATCH 3/4] cifs: return proper error code in statfs(2)
Date: Mon,  8 Mar 2021 12:00:49 -0300	[thread overview]
Message-ID: <20210308150050.19902-3-pc@cjr.nz> (raw)
In-Reply-To: <20210308150050.19902-1-pc@cjr.nz>

In cifs_statfs(), if server->ops->queryfs is not NULL, then we should
use its return value rather than always returning 0.  Instead, use rc
variable as it is properly set to 0 in case there is no
server->ops->queryfs.

Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
---
 fs/cifs/cifsfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index d43e935d2df4..099ad9f3660b 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -290,7 +290,7 @@ cifs_statfs(struct dentry *dentry, struct kstatfs *buf)
 		rc = server->ops->queryfs(xid, tcon, cifs_sb, buf);
 
 	free_xid(xid);
-	return 0;
+	return rc;
 }
 
 static long cifs_fallocate(struct file *file, int mode, loff_t off, loff_t len)
-- 
2.30.1


  parent reply	other threads:[~2021-03-08 15:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 15:00 [PATCH 1/4] cifs: print MIDs in decimal notation Paulo Alcantara
2021-03-08 15:00 ` [PATCH 2/4] cifs: change noisy error message to FYI Paulo Alcantara
2021-03-08 15:12   ` Aurélien Aptel
2021-03-09  0:40   ` ronnie sahlberg
2021-03-08 15:00 ` Paulo Alcantara [this message]
2021-03-08 15:13   ` [PATCH 3/4] cifs: return proper error code in statfs(2) Aurélien Aptel
2021-03-08 21:08   ` Steve French
2021-03-08 22:21     ` Paulo Alcantara
2021-03-09  0:40   ` ronnie sahlberg
2021-03-08 15:00 ` [PATCH 4/4] cifs: do not send close in compound create+close requests Paulo Alcantara
2021-03-08 15:29   ` Aurélien Aptel
2021-03-08 21:06   ` Steve French
2021-03-08 22:22     ` Paulo Alcantara
2021-03-09  0:43   ` ronnie sahlberg
2021-03-08 15:10 ` [PATCH 1/4] cifs: print MIDs in decimal notation Aurélien Aptel
2021-03-09  0:39 ` ronnie sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210308150050.19902-3-pc@cjr.nz \
    --to=pc@cjr.nz \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox