Re: [PATCH v2] cifs: fix regression when mounting shares with prefix paths

Paulo Alcantara
2021-05-04T16:48:01Z

David Disseldorp <ddiss@suse.de> writes:

> On Mon, 3 May 2021 11:55:26 -0300, Paulo Alcantara wrote:
>> - rc = cifs_setup_volume_info(cifs_sb->ctx, NULL, old_ctx->UNC);
>> + rc = cifs_setup_volume_info(cifs_sb->ctx, NULL, NULL);
>
> IIUC, with the new behaviour, this call becomes pretty much an
> if (!cifs_sb->ctx->username)
> root = ERR_PTR(-EINVAL);

Yeah. We should get rid of the damn thing at some point. I've just
tried to keep the logic we currently have in fs/cifs/connect.c by
composing new options based upon the chased DFS referrals.

Thanks for pointing it out!