Re: [PATCH v6 07/14] ksmbd: use ksmbd_req_buf_next() in ksmbd_smb2_check_message()

Ralph Boehme
2021-10-05T04:29:03Z

[-- Attachment #1.1: Type: text/plain, Size: 781 bytes --]

Am 03.10.21 um 02:59 schrieb Namjae Jeon:
> 2021-10-02 22:12 GMT+09:00, Ralph Boehme <slow@samba.org>:
>> No change in behaviour.
> It is better to add patch subject here if there is nothing to write
> patch description.
> i.e. "Use ksmbd_req_buf_next() in ksmbd_smb2_check_message()"
See the mail subject, that's the patch subject.

In Samba we often help reviewers reviewing large patchsets that may
include a lot of small preparational/cleanup patches with a sentence
like "No change in behaviour" to give a hint which patches are critical
and need extra care when reviewing (ie all others) and which may not
require this.

-slow

--
Ralph Boehme, Samba Team https://samba.org/
SerNet Samba Team Lead https://sernet.de/en/team-samba

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]