Re: [PATCH v6 07/14] ksmbd: use ksmbd_req_buf_next() in ksmbd_smb2_check_message()

Namjae Jeon
2021-10-03T00:59:31Z

2021-10-02 22:12 GMT+09:00, Ralph Boehme <slow@samba.org>:
> No change in behaviour.
It is better to add patch subject here if there is nothing to write
patch description.
i.e. "Use ksmbd_req_buf_next() in ksmbd_smb2_check_message()"

>
> Cc: Namjae Jeon <linkinjeon@kernel.org>
> Cc: Tom Talpey <tom@talpey.com>
> Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> Cc: Steve French <smfrench@gmail.com>
> Cc: Hyunchul Lee <hyc.lee@gmail.com>
> Signed-off-by: Ralph Boehme <slow@samba.org>
> ---
> fs/ksmbd/smb2misc.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/fs/ksmbd/smb2misc.c b/fs/ksmbd/smb2misc.c
> index c1f0f10ca9f9..76f53db7db8d 100644
> --- a/fs/ksmbd/smb2misc.c
> +++ b/fs/ksmbd/smb2misc.c
> @@ -329,17 +329,12 @@ static int smb2_validate_credit_charge(struct smb2_hdr
> *hdr)
>
> int ksmbd_smb2_check_message(struct ksmbd_work *work)
> {
> - struct smb2_pdu *pdu = work->request_buf;
> + struct smb2_pdu *pdu = ksmbd_req_buf_next(work);
> struct smb2_hdr *hdr = &pdu->hdr;
> int command;
> __u32 clc_len; /* calculated length */
> __u32 len = get_rfc1002_len(pdu);
>
> - if (work->next_smb2_rcv_hdr_off) {
> - pdu = ksmbd_req_buf_next(work);
> - hdr = &pdu->hdr;
> - }
> -
> if (le32_to_cpu(hdr->NextCommand) > 0) {
> len = le32_to_cpu(hdr->NextCommand);
> } else if (work->next_smb2_rcv_hdr_off) {
> --
> 2.31.1
>
>