Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Yupeng Li <liyupeng@zbhlos.com>
To: sfrench@samba.org, linux-cifs@vger.kernel.org,
	samba-technical@lists.samba.org, linux-kernel@vger.kernel.org
Cc: Eugene Korenevsky <ekorenevsky@astralinux.ru>,
	Steve French <stfrench@microsoft.com>,
	Yupeng Li <liyupeng@zbhlos.com>
Subject: [PATCH] cifs: fix FILE_BOTH_DIRECTORY_INFO definition
Date: Thu, 24 Mar 2022 15:26:51 +0800	[thread overview]
Message-ID: <20220324072651.3418236-1-liyupeng@zbhlos.com> (raw)

From: Eugene Korenevsky <ekorenevsky@astralinux.ru>

commit 9bbf8662a27b56358366027d1a77c0676f85b222 upstream.

The size of FILE_BOTH_DIRECTORY_INFO.ShortName must be 24 bytes, not 12
(see MS-FSCC documentation).

Signed-off-by: Eugene Korenevsky <ekorenevsky@astralinux.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
---
 fs/cifs/cifspdu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h
index 1ce733f3582f..504a20250f73 100644
--- a/fs/cifs/cifspdu.h
+++ b/fs/cifs/cifspdu.h
@@ -2588,7 +2588,7 @@ typedef struct {
 	__le32 EaSize; /* length of the xattrs */
 	__u8   ShortNameLength;
 	__u8   Reserved;
-	__u8   ShortName[12];
+	__u8   ShortName[24];
 	char FileName[1];
 } __attribute__((packed)) FILE_BOTH_DIRECTORY_INFO; /* level 0x104 FFrsp data */
 
-- 
2.34.1


             reply	other threads:[~2022-03-24  7:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24  7:26 Yupeng Li [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-01-11 14:42 [PATCH] cifs: fix FILE_BOTH_DIRECTORY_INFO definition Eugene Korenevsky
2022-01-11  8:36 Eugene Korenevsky
2022-01-12  5:59 ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220324072651.3418236-1-liyupeng@zbhlos.com \
    --to=liyupeng@zbhlos.com \
    --cc=ekorenevsky@astralinux.ru \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox