From: Paulo Alcantara <pc@cjr.nz>
To: linux-cifs@vger.kernel.org, smfrench@gmail.com
Cc: Paulo Alcantara <pc@cjr.nz>
Subject: [PATCH 2/2] cifs: force new session setup and tcon for dfs
Date: Thu, 31 Mar 2022 15:01:51 -0300 [thread overview]
Message-ID: <20220331180151.5301-2-pc@cjr.nz> (raw)
In-Reply-To: <20220331180151.5301-1-pc@cjr.nz>
Do not reuse existing sessions and tcons in DFS failover as it might
connect to different servers and shares.
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
---
fs/cifs/connect.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 3ca06bd88b6e..3956672a11ae 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -536,8 +536,11 @@ int cifs_reconnect(struct TCP_Server_Info *server, bool mark_smb_session)
return __cifs_reconnect(server, mark_smb_session);
}
spin_unlock(&cifs_tcp_ses_lock);
-
- return reconnect_dfs_server(server, mark_smb_session);
+ /*
+ * Ignore @mark_smb_session and invalidate all sessions & tcons as we might be connecting to
+ * a different server or share during failover.
+ */
+ return reconnect_dfs_server(server, true);
}
#else
int cifs_reconnect(struct TCP_Server_Info *server, bool mark_smb_session)
--
2.35.1
next prev parent reply other threads:[~2022-03-31 18:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 18:01 [PATCH 1/2] cifs: fix potential race with cifsd thread Paulo Alcantara
2022-03-31 18:01 ` Paulo Alcantara [this message]
2022-03-31 19:49 ` [PATCH 2/2] cifs: force new session setup and tcon for dfs Enzo Matsumiya
2022-04-01 16:25 ` Paulo Alcantara
2022-04-01 3:17 ` Shyam Prasad N
2022-04-01 16:30 ` Paulo Alcantara
2022-04-01 16:51 ` [PATCH v2] " Paulo Alcantara
2022-04-01 3:23 ` [PATCH 1/2] cifs: fix potential race with cifsd thread Shyam Prasad N
2022-04-01 16:30 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331180151.5301-2-pc@cjr.nz \
--to=pc@cjr.nz \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox