From: Enzo Matsumiya <ematsumiya@suse.de>
To: Ronnie Sahlberg <lsahlber@redhat.com>
Cc: linux-cifs <linux-cifs@vger.kernel.org>,
Steve French <smfrench@gmail.com>
Subject: Re: [PATCH] cifs: cache dirent names for cached directories
Date: Wed, 4 May 2022 15:27:21 -0300 [thread overview]
Message-ID: <20220504182721.xywno7d3ihfxk5dr@cyberdelia> (raw)
In-Reply-To: <20220504014407.2301906-2-lsahlber@redhat.com>
Just another nitpick
On 05/04, Ronnie Sahlberg wrote:
<snip>
>@@ -776,7 +791,8 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
> struct cifs_fid *pfid;
> struct dentry *dentry;
>
>- if (tcon->nohandlecache)
>+ if (tcon == NULL || tcon->nohandlecache ||
>+ is_smb1_server(tcon->ses->server))
> return -ENOTSUPP;
>
> if (cifs_sb->root == NULL)
This last hunk looks unrelated to the original topic. Could it be sent
as a separate patch please? This helps tracking when doing
backports/bisects.
Cheers,
Enzo
next prev parent reply other threads:[~2022-05-04 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 1:44 cache dirent names for the cached directory while we hold a lease Ronnie Sahlberg
2022-05-04 1:44 ` [PATCH] cifs: cache dirent names for cached directories Ronnie Sahlberg
2022-05-04 1:55 ` Paulo Alcantara
2022-05-04 16:54 ` Enzo Matsumiya
2022-05-09 23:33 ` ronnie sahlberg
2022-05-10 0:01 ` ronnie sahlberg
2022-05-04 18:27 ` Enzo Matsumiya [this message]
2022-05-04 22:12 ` Leif Sahlberg
-- strict thread matches above, loose matches on Subject: below --
2022-05-03 7:09 Patch to add caching od directory entries for the cache dir Ronnie Sahlberg
2022-05-03 7:09 ` [PATCH] cifs: cache dirent names for cached directories Ronnie Sahlberg
2022-05-03 7:19 ` Steve French
2022-05-03 23:55 ` Paulo Alcantara
2022-05-04 1:44 ` ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504182721.xywno7d3ihfxk5dr@cyberdelia \
--to=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox