From: David Disseldorp <ddiss@samba.org>
To: Steve French via samba-technical <samba-technical@lists.samba.org>
Cc: Steve French <smfrench@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>,
Samba Technical <samba-technical@lists.samba.org>
Subject: Re: [PATCH][SMB3] Add defines for various newer FSCTLs
Date: Mon, 23 May 2022 12:13:47 +0200 [thread overview]
Message-ID: <20220523121347.46d2b764@samba.org> (raw)
In-Reply-To: <CAH2r5mveWTtio_Aei3VEht6KaxU6quSgwgopvXbFfMtE40q0YQ@mail.gmail.com>
Patch looks fine to me:
Reviewed-by: David Disseldorp <ddiss@suse.de>
On Sun, 22 May 2022 19:09:34 -0500, Steve French via samba-technical wrote:
> #define FSCTL_DUPLICATE_EXTENTS_TO_FILE 0x00098344
> +#define FSCTL_DUPLICATE_EXTENTS_TO_FILE_EX 0x000983E8
This one looks interesting - I wonder what kind of client use it gets.
FICLONERANGE / BTRFS_IOC_CLONE_RANGE is atomic, so it should be possible
to extend Samba's current dup-extents support to handle the new flag
(DUPLICATE_EXTENTS_DATA_EX_SOURCE_ATOMIC) without needing any lower
level changes.
Cheers, David
prev parent reply other threads:[~2022-05-23 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 23:36 [PATCH][SMB3] Add defines for various newer FSCTLs Steve French
2022-05-23 0:09 ` Steve French
2022-05-23 10:13 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523121347.46d2b764@samba.org \
--to=ddiss@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox