From: Sam James <sam@gentoo.org>
To: linux-cifs@vger.kernel.org
Cc: Sam James <sam@gentoo.org>
Subject: [PATCH 2/2] getcifsacl, setcifsacl: add missing <endian.h> include for le32toh
Date: Fri, 24 Jun 2022 05:54:32 +0100 [thread overview]
Message-ID: <20220624045432.991655-2-sam@gentoo.org> (raw)
In-Reply-To: <20220624045432.991655-1-sam@gentoo.org>
Needed to fix build on musl libc. It only works by chance on glibc
because of transitive includes (which could break at any time).
Example failure:
```
getcifsacl.c: In function 'print_ace':
getcifsacl.c:284:16: warning: implicit declaration of function 'le16toh' [-Wimplicit-function-declaration]
284 | size = le16toh(pace->size);
| ^~~~~~~
```
Bug: https://bugs.gentoo.org/842195
Signed-off-by: Sam James <sam@gentoo.org>
---
getcifsacl.c | 1 +
setcifsacl.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/getcifsacl.c b/getcifsacl.c
index d69d40a..123d11e 100644
--- a/getcifsacl.c
+++ b/getcifsacl.c
@@ -23,6 +23,7 @@
#include "config.h"
#endif /* HAVE_CONFIG_H */
+#include <endian.h>
#include <string.h>
#include <getopt.h>
#include <stdint.h>
diff --git a/setcifsacl.c b/setcifsacl.c
index e925d59..84cd0b3 100644
--- a/setcifsacl.c
+++ b/setcifsacl.c
@@ -38,6 +38,7 @@
#include "config.h"
#endif /* HAVE_CONFIG_H */
+#include <endian.h>
#include <string.h>
#include <getopt.h>
#include <stdint.h>
--
2.36.1
next prev parent reply other threads:[~2022-06-24 4:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 4:54 [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX Sam James
2022-06-24 4:54 ` Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-16 0:43 Sam James
2022-08-16 0:43 ` [PATCH 2/2] getcifsacl, setcifsacl: add missing <endian.h> include for le32toh Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624045432.991655-2-sam@gentoo.org \
--to=sam@gentoo.org \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox