From: "Atte Heikkilä" <atteh.mailbox@gmail.com>
To: tom@talpey.com
Cc: atteh.mailbox@gmail.com, linkinjeon@kernel.org,
linux-cifs@vger.kernel.org, senozhatsky@chromium.org,
smfrench@gmail.com
Subject: Re: [PATCH v3] ksmbd: update documentation
Date: Wed, 14 Sep 2022 14:09:18 +0300 [thread overview]
Message-ID: <20220914110918.5720-1-atteh.mailbox@gmail.com> (raw)
In-Reply-To: <388d1257-419e-f0c8-348f-587f5c0a51ee@talpey.com>
On Tue, 13 Sep 2022 12:02:47 -0700, Tom Talpey wrote:
> On 9/12/2022 4:54 PM, Namjae Jeon wrote:
>> 2022-09-13 8:38 GMT+09:00, Tom Talpey <tom@talpey.com>:
>>>
>>> I missed this in the v2 match - are you intentionally moving the
>>> ksmbd.conf file to /usr/local/etc? That seems a very mysterious
>>> location. Nothing on my vanilla installed system places anything
>>> in there.
>> To avoid conflicts with the existing distribution package, the default
>> location as far as I know is /usr/local/etc. And it can be changed
>> with --sysconfdir. It is same with samba.
>
> I totally disagree with this. The kernel server is part of, well,
> the kernel, and loading the kernel should not depend on a path like
> /usr/local/etc.
I really don't understand what this means. The dependency to the
sysconfdir path isn't ksmbd's, it's ksmbd-tools'.
> Also, nothing I know, including Samba, is deployed
> with such a directory in my experience. I find smb.conf in /etc/samba.
Yes, that is because your distribution builds it for you. If you build it
yourself, and don't want to collide with your distribution's packaged
version of it, then you choose some prefix other than /usr.
>
> Where are the ksmbd.<foo> helpers installed by default? /usr/local/sbin?
> On my standard Ubuntu install (and presumably Debian?) they are in
> /sbin.
Yes, the GNU autoconf default sbindir is /usr/local/sbin since the default
prefix is /usr/local. It is distinct from the sbindir your distribution's
packages use. Your /sbin is (likely) a symlink to /usr/sbin and the
distribution's packages install in the /usr prefix. The /etc sysconfdir
is associated with the /usr prefix. You can also check what FHS has to
say about /usr/local if you'd like.
Namjae's way of running configure is correct. It's either this or colliding
with file paths used by the packaged ksmbd-tools, which isn't a good idea.
>
> Tom.
>
>>> Also, doesn't this file need to exist before step 2??
>> Ah, Yes. Will switch them.
>>
>> Thanks for your review!
>>>
>>> Tom.
>>>
>>>
>>>
>>
>
next prev parent reply other threads:[~2022-09-14 11:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 9:25 [PATCH v2] ksmbd: fix incorrect handling of iterate_dir Namjae Jeon
2022-09-09 9:25 ` [PATCH v3] ksmbd: update documentation Namjae Jeon
2022-09-12 23:38 ` Tom Talpey
2022-09-12 23:54 ` Namjae Jeon
2022-09-13 19:02 ` Tom Talpey
2022-09-14 10:36 ` Namjae Jeon
2022-09-14 11:09 ` Atte Heikkilä [this message]
2022-09-15 18:25 ` Tom Talpey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220914110918.5720-1-atteh.mailbox@gmail.com \
--to=atteh.mailbox@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox