From: Enzo Matsumiya <ematsumiya@suse.de>
To: Tom Talpey <tom@talpey.com>
Cc: linux-cifs@vger.kernel.org, smfrench@gmail.com, pc@cjr.nz,
ronniesahlberg@gmail.com, nspmangalore@gmail.com
Subject: Re: [PATCH] cifs: verify signature only for valid responses
Date: Mon, 19 Sep 2022 12:15:36 -0300 [thread overview]
Message-ID: <20220919151536.rqwodfkrzuf4hzte@suse.de> (raw)
In-Reply-To: <20220919002158.wgta4konh6c4wfjr@suse.de>
On 09/18, Enzo Matsumiya wrote:
> but if we consider that other messages with status !=
>STATUS_SUCCESS have their signatures correctly computed (apparently),
>then I'd guess there's something wrong with computing signatures for
>STATUS_END_OF_FILE responses.
Correcting myself here: messages with status != STATUS_SUCCESS and !=
STATUS_END_OF_FILE take different path that never reaches ->calc_signature().
>Sent this just now:
>https://lore.kernel.org/linux-cifs/20220918235442.2981-1-ematsumiya@suse.de/T/#u
So I guess this patch is sufficient for now.
Cheers,
Enzo
next prev parent reply other threads:[~2022-09-19 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 2:07 [PATCH] cifs: verify signature only for valid responses Enzo Matsumiya
2022-09-17 14:24 ` Tom Talpey
2022-09-17 16:28 ` Enzo Matsumiya
2022-09-17 16:52 ` Enzo Matsumiya
2022-09-18 0:10 ` Tom Talpey
2022-09-19 0:21 ` Enzo Matsumiya
2022-09-19 15:15 ` Enzo Matsumiya [this message]
2022-09-20 19:04 ` Tom Talpey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919151536.rqwodfkrzuf4hzte@suse.de \
--to=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@cjr.nz \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox