Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@manguebit.com>
To: smfrench@gmail.com
Cc: linux-cifs@vger.kernel.org, Paulo Alcantara <pc@manguebit.com>
Subject: [PATCH 1/5] cifs: get rid of cifs_mount_ctx::{origin,leaf}_fullpath
Date: Wed, 29 Mar 2023 17:14:19 -0300	[thread overview]
Message-ID: <20230329201423.32134-1-pc@manguebit.com> (raw)

leaf_fullpath is now part of smb3_fs_context structure, while
origin_fullpath is just a variable in __dfs_mount_share() that is used
when final tcon is available.

Get rid of those fields in cifs_mount_ctx structure and no-op
kfree()'s.

Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
---
 fs/cifs/cifsglob.h | 1 -
 fs/cifs/connect.c  | 2 --
 2 files changed, 3 deletions(-)

diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 08a73dcb7786..c5e3a0fc7983 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -1750,7 +1750,6 @@ struct cifs_mount_ctx {
 	struct TCP_Server_Info *server;
 	struct cifs_ses *ses;
 	struct cifs_tcon *tcon;
-	char *origin_fullpath, *leaf_fullpath;
 	struct list_head dfs_ses_list;
 };
 
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 1cbb90587995..ef50f603e640 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3454,8 +3454,6 @@ int cifs_mount(struct cifs_sb_info *cifs_sb, struct smb3_fs_context *ctx)
 
 error:
 	dfs_put_root_smb_sessions(&mnt_ctx.dfs_ses_list);
-	kfree(mnt_ctx.origin_fullpath);
-	kfree(mnt_ctx.leaf_fullpath);
 	cifs_mount_put_conns(&mnt_ctx);
 	return rc;
 }
-- 
2.40.0


             reply	other threads:[~2023-03-29 20:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 20:14 Paulo Alcantara [this message]
2023-03-29 20:14 ` [PATCH 2/5] cifs: get rid of unnecessary ifdef Paulo Alcantara
2023-03-29 20:25   ` ronnie sahlberg
2023-03-29 20:14 ` [PATCH 3/5] cifs: avoid races in parallel reconnects in smb1 Paulo Alcantara
2023-03-29 20:27   ` ronnie sahlberg
2023-03-30 22:59   ` Steve French
2023-03-29 20:14 ` [PATCH 4/5] cifs: prevent infinite recursion in CIFSGetDFSRefer() Paulo Alcantara
2023-03-29 20:27   ` ronnie sahlberg
2023-03-30 22:59   ` Steve French
2023-03-29 20:14 ` [PATCH 5/5] cifs: get rid of dead check in smb2_reconnect() Paulo Alcantara
2023-03-29 20:28   ` ronnie sahlberg
2023-03-30 22:59   ` Steve French
2023-03-29 20:24 ` [PATCH 1/5] cifs: get rid of cifs_mount_ctx::{origin,leaf}_fullpath ronnie sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230329201423.32134-1-pc@manguebit.com \
    --to=pc@manguebit.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox