From: Enzo Matsumiya <ematsumiya@suse.de>
To: Volker Lendecke <vl@samba.org>
Cc: linux-cifs@vger.kernel.org
Subject: Re: [PATCH 0/3] Simplify SMB2_open_init
Date: Thu, 30 Mar 2023 19:20:01 -0300 [thread overview]
Message-ID: <20230330222001.5vq5b63lnwcmczr7@suse.de> (raw)
In-Reply-To: <cover.1680177540.git.vl@samba.org>
Hi Volker,
On 03/30, Volker Lendecke wrote:
>Stitching together can be done in one place, there's no need to do
>this in every add_*_context function.
>
>This supersedes the patchet in
>
>https://www.spinics.net/lists/linux-cifs/msg28087.html.
>
>Volker Lendecke (3):
> cifs: Simplify SMB2_open_init()
> cifs: Simplify SMB2_open_init()
> cifs: Simplify SMB2_open_init()
>
> fs/cifs/smb2pdu.c | 106 +++++++++++-----------------------------------
> 1 file changed, 25 insertions(+), 81 deletions(-)
Would you mind using more descriptive titles please? To make
referencing/backporting easier.
Also IMHO patches 1/3 and 3/3 could be merged into a single patch.
Aside from that, Reviewed-by: Enzo Matsumiya <ematsumiya@suse.de>
Cheers,
Enzo
next prev parent reply other threads:[~2023-03-30 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 12:04 [PATCH 0/3] Simplify SMB2_open_init Volker Lendecke
2023-03-30 12:04 ` [PATCH 1/3] cifs: Simplify SMB2_open_init() Volker Lendecke
2023-03-30 12:04 ` [PATCH 2/3] " Volker Lendecke
2023-03-30 12:04 ` [PATCH 3/3] " Volker Lendecke
2023-03-30 22:20 ` Enzo Matsumiya [this message]
2023-03-30 22:25 ` [PATCH 0/3] Simplify SMB2_open_init Steve French
2023-04-23 6:10 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330222001.5vq5b63lnwcmczr7@suse.de \
--to=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=vl@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox