public inbox for linux-cifs@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Paulo Alcantara <pc@manguebit.com>
Cc: stable@vger.kernel.org, linux-cifs@vger.kernel.org,
	Steve French <smfrench@gmail.com>
Subject: Re: [PATCH 4/4] smb: client: improve DFS mount check
Date: Sun, 16 Jul 2023 21:10:50 +0200	[thread overview]
Message-ID: <2023071646-freeness-untrue-230d@gregkh> (raw)
In-Reply-To: <b95eb538478eab38fac638dbeaf97e70.pc@manguebit.com>

On Thu, Jul 13, 2023 at 06:48:00PM -0300, Paulo Alcantara wrote:
> Hi Greg,
> 
> Greg KH <gregkh@linuxfoundation.org> writes:
> 
> > On Wed, Jul 12, 2023 at 06:10:27PM -0300, Paulo Alcantara wrote:
> >> Paulo Alcantara <pc@manguebit.com> writes:
> >> 
> >> > Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
> >> > that are unexpected by the client, so to make it easier, assume
> >> > non-DFS mounts when the client can't get the initial DFS referral of
> >> > @ctx->UNC in dfs_mount_share().
> >> >
> >> > Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
> >> > ---
> >> >  fs/smb/client/dfs.c | 5 +++--
> >> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
> >> > index afbaef05a1f1..a7f2e0608adf 100644
> >> 
> >> Stable team, could you please pick this up as a fix for
> >> 
> >>         8e3554150d6c ("cifs: fix sharing of DFS connections")
> >> 
> >> The upstream commit is 5f2a0afa9890 ("smb: client: improve DFS mount check").
> >
> > Does not apply cleanly, can you provide a working backport?
> 
> Find attached backport of

> >From 435048ee0f477947d1d93f5a9b60b2d2df2b7554 Mon Sep 17 00:00:00 2001
> From: Paulo Alcantara <pc@manguebit.com>
> Date: Tue, 27 Jun 2023 21:24:50 -0300
> Subject: [PATCH stable v6.3] smb: client: improve DFS mount check

I'm confused, 6.3.y is end-of-life, and:

> 
> Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
> that are unexpected by the client, so to make it easier, assume
> non-DFS mounts when the client can't get the initial DFS referral of
> @ctx->UNC in dfs_mount_share().
> 
> Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
>  fs/cifs/dfs.c | 5 +++--

This file is not in the 6.4.y or any older kernel tree.

So what tree did you make this against, and where should it be applied
to?

totally confused,

greg k-h

  reply	other threads:[~2023-07-16 19:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28  0:24 [PATCH 1/4] smb: client: fix parsing of source mount option Paulo Alcantara
2023-06-28  0:24 ` [PATCH 2/4] smb: client: fix shared DFS root mounts with different prefixes Paulo Alcantara
2023-06-28 18:53   ` Paulo Alcantara
2023-06-28 20:50     ` Steve French
2023-06-28  0:24 ` [PATCH 3/4] smb: client: fix broken file attrs with nodfs mounts Paulo Alcantara
2023-06-28  0:24 ` [PATCH 4/4] smb: client: improve DFS mount check Paulo Alcantara
2023-06-28  3:51   ` Steve French
2023-07-12 21:10   ` Paulo Alcantara
2023-07-13  5:41     ` Greg KH
2023-07-13 21:48       ` Paulo Alcantara
2023-07-16 19:10         ` Greg KH [this message]
2023-07-17 15:01           ` Paulo Alcantara
2023-07-20 17:56             ` Greg KH
2023-06-28 16:22 ` [PATCH 1/4] smb: client: fix parsing of source mount option Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023071646-freeness-untrue-230d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=pc@manguebit.com \
    --cc=smfrench@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox