From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 709F5EB64DA for ; Thu, 20 Jul 2023 17:56:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231311AbjGTR43 (ORCPT ); Thu, 20 Jul 2023 13:56:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjGTR40 (ORCPT ); Thu, 20 Jul 2023 13:56:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84D6F1986; Thu, 20 Jul 2023 10:56:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2273C61BB9; Thu, 20 Jul 2023 17:56:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30A4DC433C7; Thu, 20 Jul 2023 17:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689875784; bh=eI2id0iouJJiBBpl4fQtnhYCCVgMbkJJ0Mnm7G3PtU8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m7sGrmjzeNs+zmz1j+WVHd/QQQmrmwt9ix+0sDJvVK64GK9m39crca2iDtrogUSu4 S9dSKb9X0oNiE7UjX+yZnmjfJfMnTbjHZLS6H5so8qpCU1RECHIfBDP0p3dgLkbNyy duC/qylXh2Q8I1oivKZXg4HMrHefNriEIOegMndI= Date: Thu, 20 Jul 2023 19:56:21 +0200 From: Greg KH To: Paulo Alcantara Cc: stable@vger.kernel.org, linux-cifs@vger.kernel.org, Steve French Subject: Re: [PATCH 4/4] smb: client: improve DFS mount check Message-ID: <2023072013-backyard-drown-9c3f@gregkh> References: <20230628002450.18781-1-pc@manguebit.com> <20230628002450.18781-4-pc@manguebit.com> <0bb4a367ebd7ae83dd1538965e3c0d2b.pc@manguebit.com> <2023071306-nearly-saved-a419@gregkh> <2023071646-freeness-untrue-230d@gregkh> <8497337677209ff8a9418f1a4873eb3a.pc@manguebit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8497337677209ff8a9418f1a4873eb3a.pc@manguebit.com> Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Mon, Jul 17, 2023 at 12:01:58PM -0300, Paulo Alcantara wrote: > Greg KH writes: > > > On Thu, Jul 13, 2023 at 06:48:00PM -0300, Paulo Alcantara wrote: > >> Hi Greg, > >> > >> Greg KH writes: > >> > >> > On Wed, Jul 12, 2023 at 06:10:27PM -0300, Paulo Alcantara wrote: > >> >> Paulo Alcantara writes: > >> >> > >> >> > Some servers may return error codes from REQ_GET_DFS_REFERRAL requests > >> >> > that are unexpected by the client, so to make it easier, assume > >> >> > non-DFS mounts when the client can't get the initial DFS referral of > >> >> > @ctx->UNC in dfs_mount_share(). > >> >> > > >> >> > Signed-off-by: Paulo Alcantara (SUSE) > >> >> > --- > >> >> > fs/smb/client/dfs.c | 5 +++-- > >> >> > 1 file changed, 3 insertions(+), 2 deletions(-) > >> >> > > >> >> > diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c > >> >> > index afbaef05a1f1..a7f2e0608adf 100644 > >> >> > >> >> Stable team, could you please pick this up as a fix for > >> >> > >> >> 8e3554150d6c ("cifs: fix sharing of DFS connections") > >> >> > >> >> The upstream commit is 5f2a0afa9890 ("smb: client: improve DFS mount check"). > >> > > >> > Does not apply cleanly, can you provide a working backport? > >> > >> Find attached backport of > > > >> >From 435048ee0f477947d1d93f5a9b60b2d2df2b7554 Mon Sep 17 00:00:00 2001 > >> From: Paulo Alcantara > >> Date: Tue, 27 Jun 2023 21:24:50 -0300 > >> Subject: [PATCH stable v6.3] smb: client: improve DFS mount check > > > > I'm confused, 6.3.y is end-of-life, and: > > > >> > >> Some servers may return error codes from REQ_GET_DFS_REFERRAL requests > >> that are unexpected by the client, so to make it easier, assume > >> non-DFS mounts when the client can't get the initial DFS referral of > >> @ctx->UNC in dfs_mount_share(). > >> > >> Signed-off-by: Paulo Alcantara (SUSE) > >> Signed-off-by: Steve French > >> --- > >> fs/cifs/dfs.c | 5 +++-- > > > > This file is not in the 6.4.y or any older kernel tree. > > > > So what tree did you make this against, and where should it be applied > > to? > > Err, sorry about missing the EOL of 6.3.y. The attached patch was based > on v6.3.13 from the stable tree[1], where it didn't have the rename > from "fs/cifs" to "fs/smb/client" yet. Please ignore the attached > patch. > > So, the commit > > 5f2a0afa9890 ("smb: client: improve DFS mount check") > > should be applied to 6.4.y. I've checked that it applies cleanly > against linux-6.4.y from the linux-stable-rc tree[2]. Now queued up, thanks. greg k-h