From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEB7C83F32 for ; Tue, 29 Aug 2023 13:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233412AbjH2Ndy (ORCPT ); Tue, 29 Aug 2023 09:33:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236237AbjH2Ndh (ORCPT ); Tue, 29 Aug 2023 09:33:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F810CC2; Tue, 29 Aug 2023 06:33:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2067065786; Tue, 29 Aug 2023 13:33:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F14FC433C8; Tue, 29 Aug 2023 13:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693315982; bh=gctukiBejRCoBY7mD02wGUjqchevO03zTKIwzJosmnQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=anYGYtYVEQDRZ/y+OwX/mB69AcS30GQ9OZ/u1GX9SeqLXAZewE+Kcs275fdr0WPrW M4NLRlRSY6+pnibfsrMoJp7N4Hv+k3oKq75fSnB9fePCasgyBhIkiZq4RLbdraAjst dNBVUbeN2KuGhTmtcZmp4mA535HbOp9m6GikQPMCe/HM3MJs9iO2ZQtTTHwIp9kdFR bR4vjcA80SaOaVh1p3vhmUx88zBX/JzDP206JXGWPEUHI4/llrMG1TRW+Fv9aWHWjV PJ1EQYwZaXh3PPzStI8dFiqZYnmhwUZtxvsnYcQurCAB+Uf9gKEJ1YGI1MqejFm3dq jc61uDLT8XX+w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Shyam Prasad N , Bharath SM , Steve French , Sasha Levin , sfrench@samba.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Subject: [PATCH AUTOSEL 6.1 09/15] cifs: add a warning when the in-flight count goes negative Date: Tue, 29 Aug 2023 09:32:39 -0400 Message-Id: <20230829133245.520176-9-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230829133245.520176-1-sashal@kernel.org> References: <20230829133245.520176-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.49 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org From: Shyam Prasad N [ Upstream commit e4645cc2f1e2d6f268bb8dcfac40997c52432aed ] We've seen the in-flight count go into negative with some internal stress testing in Microsoft. Adding a WARN when this happens, in hope of understanding why this happens when it happens. Signed-off-by: Shyam Prasad N Reviewed-by: Bharath SM Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/smb/client/smb2ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c index 4fd377185c2ca..d5586f731dbc3 100644 --- a/fs/smb/client/smb2ops.c +++ b/fs/smb/client/smb2ops.c @@ -93,6 +93,7 @@ smb2_add_credits(struct TCP_Server_Info *server, server->conn_id, server->hostname, *val, add, server->in_flight); } + WARN_ON_ONCE(server->in_flight == 0); server->in_flight--; if (server->in_flight == 0 && ((optype & CIFS_OP_MASK) != CIFS_NEG_OP) && -- 2.40.1