Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: chenxiaosong@chenxiaosong.com
To: linkinjeon@kernel.org, sfrench@samba.org,
	senozhatsky@chromium.org, tom@talpey.com,
	linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
	pc@manguebit.com, ronniesahlberg@gmail.com,
	sprasad@microsoft.com, bharathsm@microsoft.com
Cc: chenxiaosong@kylinos.cn, liuzhengyuan@kylinos.cn,
	huhai@kylinos.cn, liuyun01@kylinos.cn,
	ChenXiaoSong <chenxiaosong@chenxiaosong.com>
Subject: [PATCH 3/8] smb/server: remove useless variable assignment in smb2_open()
Date: Tue, 20 Aug 2024 14:33:14 +0000	[thread overview]
Message-ID: <20240820143319.274033-4-chenxiaosong@chenxiaosong.com> (raw)
In-Reply-To: <20240820143319.274033-1-chenxiaosong@chenxiaosong.com>

From: ChenXiaoSong <chenxiaosong@kylinos.cn>

The variable is already true here.

Signed-off-by: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
---
 fs/smb/server/smb2pdu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 119c1ba5f255..4e87bbac2662 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -3100,7 +3100,6 @@ int smb2_open(struct ksmbd_work *work)
 			goto err_out;
 		}
 
-		file_present = true;
 		idmap = mnt_idmap(path.mnt);
 	} else {
 		if (rc != -ENOENT)
-- 
2.34.1


  parent reply	other threads:[~2024-08-20 14:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20 14:33 [PATCH 0/8] smb: fix some bugs, move duplicate definitions to common header file, and some small cleanups chenxiaosong
2024-08-20 14:33 ` [PATCH 1/8] smb/server: fix return value of smb2_open() chenxiaosong
2024-08-22  0:49   ` Namjae Jeon
2024-08-20 14:33 ` [PATCH 2/8] smb/server: fix potential null-ptr-deref of lease_ctx_info in smb2_open() chenxiaosong
2024-08-22  0:41   ` Namjae Jeon
2024-08-22  0:59     ` ChenXiaoSong
2024-08-20 14:33 ` chenxiaosong [this message]
2024-08-22  0:47   ` [PATCH 3/8] smb/server: remove useless variable assignment " Namjae Jeon
2024-08-20 14:33 ` [PATCH 4/8] smb/client: fix typo: GlobalMid_Sem -> GlobalMid_Lock chenxiaosong
2024-08-22  0:21   ` Namjae Jeon
2024-08-20 14:33 ` [PATCH 5/8] smb/server: update misguided comment of smb2_allocate_rsp_buf() chenxiaosong
2024-08-22  0:48   ` Namjae Jeon
2024-08-20 14:33 ` [PATCH 6/8] smb: move some duplicate definitions to common/smbacl.h chenxiaosong
2024-08-21 19:51   ` Steve French
2024-08-21 23:48   ` Namjae Jeon
2024-08-22  0:16     ` chenxiaosong
2024-08-20 14:33 ` [PATCH 7/8] smb/client: fix typo: STATUS_MCA_OCCURED -> STATUS_MCA_OCCURRED chenxiaosong
2024-08-21 17:53   ` Steve French
2024-08-21 23:57   ` Namjae Jeon
2024-08-22  0:10     ` chenxiaosong
2024-08-22  0:11     ` Steve French
2024-08-20 14:33 ` [PATCH 8/8] smb: move SMB2 Status code to common header file chenxiaosong
2024-08-21 19:51   ` Steve French
2024-08-21 23:40   ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240820143319.274033-4-chenxiaosong@chenxiaosong.com \
    --to=chenxiaosong@chenxiaosong.com \
    --cc=bharathsm@microsoft.com \
    --cc=chenxiaosong@kylinos.cn \
    --cc=huhai@kylinos.cn \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyun01@kylinos.cn \
    --cc=liuzhengyuan@kylinos.cn \
    --cc=pc@manguebit.com \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=sfrench@samba.org \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox