From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B71519AD97; Sat, 12 Oct 2024 11:28:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728732503; cv=none; b=H4EhnOzYeFcrmi2WweAOIcn/LBYkmVTvEYaDK4f5shD61zC4FylnyKDcg7wl1PltUwE8q4BB/mVZbhK2SyLHeTu2HgaFKMkrz4EKyzOmQ6RBCFg0uO9OWImWBi2opmVbUFKhVc7uE+XhFEjQGq3YxtTDhBLIenWZWltRD8rU4oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728732503; c=relaxed/simple; bh=eIkWCsCR3NMdmMgKN/NA1unm/enojmFve45QFyCY8tA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Davv7PfyLc+ZA1hCRuA4NXzewPY6ymGasiqtMS4fuGiX4+Zmqm5NpUXNziuD+LrNFpQVcwo+lXjC7RKX1Y+cuFsiYvmjLNKI672RPSwkTdoMbniuBucqdGrW6iBYESQEMT37MxiQkUwEdv0JfW0kWpwd7lHEsWwiPwGnBWPAelc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y/ORg131; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y/ORg131" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD6ABC4CECE; Sat, 12 Oct 2024 11:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728732503; bh=eIkWCsCR3NMdmMgKN/NA1unm/enojmFve45QFyCY8tA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y/ORg1317O0Lws7XSTavjJsCkyVFaoFzizCA4r5pnE4mZ9gV9jRpuVZegBsXofM9I uolRGLxCFOoh1xDtyPGlAsQBpNcJoTZyyeL7iLmn6nyfPch0VWpMwPGaqb6/kkCVkC Ds4O0p1LP9BQ3Bu1FRUgru+1/Q5OlBWr8jQ6KuvW33MFn1rAxdeYPYXL/b14goyjrB JJn114DUibtNqAdLVvBISefYOfu49iwCJZh5i8burqxMehRJusp0mczlhNehTafqtI u1WJcjrzI+IBIIM6IpUXGTYNaPZwKviP89/VON7kMdojIzpkJ6yXEnTTTfKI/iUQH/ 8g6YhMIHQ3OmA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Namjae Jeon , Sangsoo Lee , Steve French , Sasha Levin , sfrench@samba.org, linux-cifs@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 02/13] ksmbd: override fsids for smb2_query_info() Date: Sat, 12 Oct 2024 07:27:51 -0400 Message-ID: <20241012112818.1763719-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241012112818.1763719-1-sashal@kernel.org> References: <20241012112818.1763719-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.112 Content-Transfer-Encoding: 8bit From: Namjae Jeon [ Upstream commit f6bd41280a44dcc2e0a25ed72617d25f586974a7 ] Sangsoo reported that a DAC denial error occurred when accessing files through the ksmbd thread. This patch override fsids for smb2_query_info(). Reported-by: Sangsoo Lee Signed-off-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/smb/server/smb2pdu.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index d97c7982bb3ee..d018148913615 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -5321,6 +5321,11 @@ int smb2_query_info(struct ksmbd_work *work) ksmbd_debug(SMB, "GOT query info request\n"); + if (ksmbd_override_fsids(work)) { + rc = -ENOMEM; + goto err_out; + } + switch (req->InfoType) { case SMB2_O_INFO_FILE: ksmbd_debug(SMB, "GOT SMB2_O_INFO_FILE\n"); @@ -5339,6 +5344,7 @@ int smb2_query_info(struct ksmbd_work *work) req->InfoType); rc = -EOPNOTSUPP; } + ksmbd_revert_fsids(work); if (!rc) { rsp->StructureSize = cpu_to_le16(9); @@ -5348,6 +5354,7 @@ int smb2_query_info(struct ksmbd_work *work) le32_to_cpu(rsp->OutputBufferLength)); } +err_out: if (rc < 0) { if (rc == -EACCES) rsp->hdr.Status = STATUS_ACCESS_DENIED; -- 2.43.0