Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Pavel Shilovsky <pshilovsky@samba.org>
Cc: linux-cifs@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [PATCH cifs-utils] configure.ac: libtalloc is now mandatory
Date: Thu, 26 Dec 2024 21:42:12 +0100	[thread overview]
Message-ID: <20241226204212.2311264-1-thomas.petazzoni@bootlin.com> (raw)

Since commit c6bf4d9a59809fbb0c22ef9eb167c099ab8089fb ("Implement
CLDAP Ping to find the closest site"), libtalloc is mandatory to
cifs-utils. This needs to be reflected in the configure.ac script to
get a failure at configure time and not build time.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 configure.ac | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/configure.ac b/configure.ac
index b84c41f..b74358d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -133,6 +133,10 @@ AC_CHECK_HEADERS([arpa/inet.h ctype.h fcntl.h inttypes.h limits.h mntent.h netdb
 AC_CHECK_HEADERS([sys/fsuid.h])
 AC_CHECK_FUNC(setfsuid, , [AC_MSG_ERROR([System does not support setfsuid()])])
 
+# libtalloc
+AC_CHECK_HEADERS([talloc.h], ,[AC_MSG_ERROR([talloc.h not found, consider installing libtalloc-devel.])])
+AC_CHECK_LIB(talloc, talloc_init, ,[AC_MSG_ERROR([talloc.h not found, consider installing libtalloc-devel.])])
+
 # FIXME: add test(s) to autodisable these flags when compiler/linker don't support it
 if test $enable_pie != "no"; then
 	PIE_CFLAGS="-fpie -pie"
@@ -177,16 +181,6 @@ if test $enable_cifsupcall != "no"; then
 			[Whether the krb5_keyblock struct has a keyvalue property])
 	fi
 fi
-if test $enable_cifsupcall != "no"; then
-	AC_CHECK_HEADERS([talloc.h], , [
-				if test "$enable_cifsupcall" = "yes"; then
-					AC_MSG_ERROR([talloc.h not found, consider installing libtalloc-devel.])
-				else
-					AC_MSG_WARN([talloc.h not found, consider installing libtalloc-devel. Disabling cifs.upcall.])
-					enable_cifsupcall="no"
-				fi
-			])
-fi
 if test $enable_cifsupcall != "no" -o $enable_cifsidmap != "no"; then
 	AC_CHECK_HEADERS([keyutils.h], , [
 				if test "$enable_cifsupcall" = "yes"; then
-- 
2.47.0


             reply	other threads:[~2024-12-26 20:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 20:42 Thomas Petazzoni [this message]
2025-01-20 16:09 ` [PATCH cifs-utils] configure.ac: libtalloc is now mandatory Paulo Alcantara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241226204212.2311264-1-thomas.petazzoni@bootlin.com \
    --to=thomas.petazzoni@bootlin.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=pshilovsky@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox