From: "Pali Rohár" <pali@kernel.org>
To: Steve French <smfrench@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: Fix endian types in struct rfc1002_session_packet
Date: Sun, 19 Jan 2025 20:28:50 +0100 [thread overview]
Message-ID: <20250119192850.6dat6hi7shoajo5d@pali> (raw)
In-Reply-To: <CAH2r5mu+P1n18+EgdzqB_FmcEWXoaEqacqa6osKHtb05B1bBbQ@mail.gmail.com>
On Sunday 19 January 2025 13:21:39 Steve French wrote:
> > All fields in struct rfc1002_session_packet are in big endian. This is
> > because all NetBIOS packet headers are in big endian as opposite of SMB
> >structures which are in little endian.
> > Therefore use __be16 and __be32 types instead of __u16 and __u32 in
> >struct rfc1002_session_packet.
> >
> >Reported-by: kernel test robot <lkp@intel.com>
>
> Do you have a link to the kernel bot reported by (email?)
I should have it somewhere in my mailbox. I if needed I can try to find it.
But robot reported this issue for my own branch (not the master one). So
I though that it is not important to mention exact link for some of my
change which was work-in-progress.
In any case, robot found the issue with incorrect endianity types, so I
wanted to give credits for this robot. Anyway, those type changes should
not change compiled code, just allows code analysis tool to diagnose
other issues.
next prev parent reply other threads:[~2025-01-19 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-19 19:21 [PATCH] cifs: Fix endian types in struct rfc1002_session_packet Steve French
2025-01-19 19:28 ` Pali Rohár [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-01 13:21 Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250119192850.6dat6hi7shoajo5d@pali \
--to=pali@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox