From: "Pali Rohár" <pali@kernel.org>
To: Steve French <smfrench@gmail.com>
Cc: Paulo Alcantara <pc@manguebit.com>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 0/4] cifs: Handle all name surrogate reparse points
Date: Tue, 4 Mar 2025 21:37:42 +0100 [thread overview]
Message-ID: <20250304203742.pcrx3ppkxc6dab4c@pali> (raw)
In-Reply-To: <CAH2r5muzB=R2TA2-=XM3juVD1dhic=Wb_JYu71LYr9YyS5cXKA@mail.gmail.com>
On Sunday 02 March 2025 19:01:00 Steve French wrote:
> On Sun, Mar 2, 2025 at 6:25 AM Pali Rohár <pali@kernel.org> wrote:
> >
> > On Sunday 23 February 2025 18:48:50 Steve French wrote:
> > > On Sun, Feb 23, 2025 at 4:23 PM Pali Rohár <pali@kernel.org> wrote:
> > > >
> > > > Hello Steve, I see that you have merged first two changes (1/4 and 2/4)
> > > > from this patch series, but the remaining (3/4 and 4/4). Is there any
> > > > reason why 3/4 and 4/4 was not taken?
> > >
> > > Mainly because I wasn't able to easily test it, and didn't get test
> > > feedback for anyone else
> > > on those two who had tried it.
> > >
> > > I am ok with looking at them again - and thx for rebasing.
> >
> > Ok, when you have a time, please look at them.
> >
> > > There are some of the 41 patches in your updated cifs branch that do look suitable or rc5
> >
> > There is "cifs: Change translation of STATUS_DELETE_PENDING to -EBUSY"
> > which stops returning -ENOENT for directory entry which still exists.
>
> IIRC - there were some objections to this if it could break any
> plausible existing application behavior, but will need to dig into the
> thread from earlier.
>
> Tom or Paulo,
> Do you remember if this is one that you had mentioned?
I have not figured out any regression for the
STATUS_DELETE_PENDING/EBUSY change.
If you have some scenario or other test case for it then please let me
know what can be wrong here.
I think that it should not cause any regression because applications on
ENOENT error cannot expect that the dir entry still existing.
prev parent reply other threads:[~2025-03-04 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-22 14:58 [PATCH 0/4] cifs: Handle all name surrogate reparse points Pali Rohár
2024-12-22 14:58 ` [PATCH 1/4] cifs: Throw -EOPNOTSUPP error on unsupported reparse point type from parse_reparse_point() Pali Rohár
2024-12-22 14:58 ` [PATCH 2/4] cifs: Treat unhandled directory name surrogate reparse points as mount directory nodes Pali Rohár
2024-12-22 14:58 ` [PATCH 3/4] cifs: Remove explicit handling of IO_REPARSE_TAG_MOUNT_POINT in inode.c Pali Rohár
2024-12-22 14:58 ` [PATCH 4/4] cifs: Improve handling of name surrogate reparse points in reparse.c Pali Rohár
2025-02-23 22:23 ` [PATCH 0/4] cifs: Handle all name surrogate reparse points Pali Rohár
2025-02-24 0:48 ` Steve French
2025-03-02 12:24 ` Pali Rohár
2025-03-03 1:01 ` Steve French
2025-03-04 20:37 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304203742.pcrx3ppkxc6dab4c@pali \
--to=pali@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox