From: Bharath SM <bharathsm.hsk@gmail.com>
To: linux-cifs@vger.kernel.org, smfrench@gmail.com,
sprasad@microsoft.com, pc@manguebit.com
Cc: Bharath SM <bharathsm@microsoft.com>, xfuren <xfuren@gmail.com>
Subject: [PATCH 3/3] smb: fix secondary channel creation issue with kerberos by populating hostname when adding channels
Date: Mon, 17 Mar 2025 15:57:27 +0530 [thread overview]
Message-ID: <20250317102727.176918-3-bharathsm@microsoft.com> (raw)
In-Reply-To: <20250317102727.176918-1-bharathsm@microsoft.com>
When mounting a share with kerberos authentication with multichannel
support, share mounts correctly, but fails to create secondary
channels. This occurs because the hostname is not populated when
adding the channels. The hostname is necessary for the userspace
cifs.upcall program to retrieve the required credentials and pass
it back to kernel, without hostname secondary channels fails
establish.
Signed-off-by: Bharath SM <bharathsm@microsoft.com>
Reported-by: xfuren <xfuren@gmail.com>
Link: https://bugzilla.samba.org/show_bug.cgi?id=15824
---
fs/smb/client/sess.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
index b45b46b1b792..f2ab8513c3ed 100644
--- a/fs/smb/client/sess.c
+++ b/fs/smb/client/sess.c
@@ -494,8 +494,7 @@ cifs_ses_add_channel(struct cifs_ses *ses,
ctx->domainauto = ses->domainAuto;
ctx->domainname = ses->domainName;
- /* no hostname for extra channels */
- ctx->server_hostname = "";
+ ctx->server_hostname = ses->server->hostname;
ctx->username = ses->user_name;
ctx->password = ses->password;
--
2.43.0
next prev parent reply other threads:[~2025-03-17 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 10:27 [PATCH 1/3] smb: minor cleanup to remove unused function declaration Bharath SM
2025-03-17 10:27 ` [PATCH 2/3] smb: mark the new channel addition log as informational log with cifs_info Bharath SM
2025-03-17 10:27 ` Bharath SM [this message]
2025-06-17 11:04 ` [PATCH 3/3] smb: fix secondary channel creation issue with kerberos by populating hostname when adding channels Shyam Prasad N
2025-06-17 13:19 ` Steve French
2025-03-18 4:01 ` [PATCH 1/3] smb: minor cleanup to remove unused function declaration Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317102727.176918-3-bharathsm@microsoft.com \
--to=bharathsm.hsk@gmail.com \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=xfuren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox