From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <chenxiaosong@chenxiaosong.com>
Cc: <david.laight.linux@gmail.com>, <chenxiaosong@kylinos.cn>,
<linkinjeon@kernel.org>, <linux-cifs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<senozhatsky@chromium.org>, <sfrench@samba.org>, <tom@talpey.com>
Subject: Re: [PATCH] smb/server: use sock_create_kern() in create_socket()
Date: Mon, 24 Mar 2025 15:11:36 -0700 [thread overview]
Message-ID: <20250324221225.73511-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250324210747.3dc899b9@pumpkin>
From: David Laight <david.laight.linux@gmail.com>
Date: Mon, 24 Mar 2025 21:07:47 +0000
> On Mon, 24 Mar 2025 06:51:55 +0000
> chenxiaosong@chenxiaosong.com wrote:
>
> > From: ChenXiaoSong <chenxiaosong@kylinos.cn>
> >
> > The socket resides in kernel space, so use sock_create_kern()
> > instead of sock_create().
>
> As in the other patches you need to worry about whether the socket
> holds a reference to the network namespace.
Right, and if you don't see any real issue, I recommend leaving
it as is for now because we have seen many refcount issues for
kernel TCP sockets.
And I totally forgot to respin my series after holiday to clean
up such callers.
https://lore.kernel.org/netdev/20241213092152.14057-1-kuniyu@amazon.com/
I'll repost v4 after the merge window with some modification
1. be less invasive as suggested by Paolo
2. use sk_net_refcnt_upgrade()
prev parent reply other threads:[~2025-03-24 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 6:51 [PATCH] smb/server: use sock_create_kern() in create_socket() chenxiaosong
2025-03-24 21:07 ` David Laight
2025-03-24 22:11 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324221225.73511-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=chenxiaosong@chenxiaosong.com \
--cc=chenxiaosong@kylinos.cn \
--cc=david.laight.linux@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox