Re: [PATCH] cifs: Improve SMB2+ stat() to work also for paths in DELETE_PENDING state

["Pali Rohár" <pali@kernel.org>]

Hello, this change is not reverse of what POSIX requires.

Delete pending state is special thing in Windows and is just a temporary
state, which may be reverted.

In POSIX, the real unlink is the final state and once unlink finish, the
directory entry is not in the parent directory anymore, and such
directory can be removed.

But on the other hand, if the file in the directory is in delete pending
state, then the directory cannot be removed. Directory can be removed
once all files are not in delete pending state anymore and are really
removed.

Any file in delete pending state is visible over SMB protocol to any
application, not just to application which opened it.

Silly rename is not an option here, because file can be put into delete
pending state by windows server itself -- which does not do any silly
rename strategy.

And for example msvcrt.dll stat() function on Windows is doing same
thing. Stat is querying also files in delete pending state.

On Monday 24 March 2025 22:53:35 Steve French wrote:
> In thinking about this patch, isn't it doing the reverse of what POSIX requires?
> 
> When querying a file in delete pending state, shouldn't be invisible
> in the namespace on the client.  Wouldn't your patch do the opposite?
> ie Doesn't it allow stat to return information about a file which
> should be invisible to everyone except the app who has it open (and if
> possible we could make this easier via a "silly rename" strategy as
> some other protocols do)?
> 
> Thoughts?
> 
> 
> 
> -- 
> Thanks,
> 
> Steve