From: Eric Biggers <ebiggers@kernel.org>
To: Namjae Jeon <linkinjeon@kernel.org>,
Steve French <smfrench@gmail.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Tom Talpey <tom@talpey.com>,
linux-cifs@vger.kernel.org
Subject: [PATCH] ksmbd: remove unnecessary softdep on crc32
Date: Tue, 13 May 2025 21:54:07 -0700 [thread overview]
Message-ID: <20250514045407.118970-1-ebiggers@kernel.org> (raw)
From: Eric Biggers <ebiggers@google.com>
ksmbd accesses crc32 using normal function calls (as opposed to e.g.
the generic crypto infrastructure's name-based algorithm resolution), so
there is no need to declare a module softdep.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/smb/server/server.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/smb/server/server.c b/fs/smb/server/server.c
index ab533c6029879..8c9c49c3a0a47 100644
--- a/fs/smb/server/server.c
+++ b/fs/smb/server/server.c
@@ -629,8 +629,7 @@ MODULE_SOFTDEP("pre: cmac");
MODULE_SOFTDEP("pre: sha256");
MODULE_SOFTDEP("pre: sha512");
MODULE_SOFTDEP("pre: aead2");
MODULE_SOFTDEP("pre: ccm");
MODULE_SOFTDEP("pre: gcm");
-MODULE_SOFTDEP("pre: crc32");
module_init(ksmbd_server_init)
module_exit(ksmbd_server_exit)
base-commit: aa94665adc28f3fdc3de2979ac1e98bae961d6ca
--
2.49.0
next reply other threads:[~2025-05-14 4:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 4:54 Eric Biggers [this message]
2025-05-14 8:45 ` [PATCH] ksmbd: remove unnecessary softdep on crc32 Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514045407.118970-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox