From: Eric Biggers <ebiggers@kernel.org>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: Steve French <smfrench@gmail.com>,
linux-cifs@vger.kernel.org, Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.org>,
Namjae Jeon <linkinjeon@kernel.org>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Bharath SM <bharathsm@microsoft.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smb: Use arc4 library instead of duplicate arc4 code
Date: Sun, 7 Sep 2025 11:55:55 -0700 [thread overview]
Message-ID: <20250907185555.GA3530@sol> (raw)
In-Reply-To: <CAN05THRE0powMS-AgXHfGT_rbkrqBA09PDA6ydzcCGzSnA-V9w@mail.gmail.com>
On Mon, Sep 08, 2025 at 04:33:18AM +1000, ronnie sahlberg wrote:
> On Mon, 8 Sept 2025 at 03:59, Steve French <smfrench@gmail.com> wrote:
> >
> > Ronnie may have additional context, but it may have been forked due to
> > unrelated restrictions on the arc4 module (that had nothing to do with
> > cifs.ko very narrow usage of arc4) breaking cifs.ko.
> >
> > Ronnie,
> > Do you remember the context?
>
> Yepp.
> The context was that to my understanding it was suggested that the
> arc4 module would be going away
> and would be removed so cifs had to stop using it. (or create its own
> private copy)
>
> Must been a misunderstanding of what/how would happen with arc4 when
> it was retired.
>
Looks like it was this thread:
https://lore.kernel.org/linux-cifs/YRXlwDBfQql36wJx@sol.localdomain/T/#u
Ard and I suggested that, *if* the MD4 code has no other users, it
should be *moved* into fs/cifs/. Unfortunately, it turned out it does
have another user: iwd uses MD4 via AF_ALG. But either way, we never
suggested adding a duplicate copy of either the MD4 or ARC4 code.
- Eric
next prev parent reply other threads:[~2025-09-07 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 3:20 [PATCH] smb: Use arc4 library instead of duplicate arc4 code Eric Biggers
2025-09-07 17:59 ` Steve French
2025-09-07 18:00 ` Steve French
2025-09-07 18:33 ` ronnie sahlberg
2025-09-07 18:55 ` Eric Biggers [this message]
2025-09-07 21:20 ` Steve French
2025-09-08 2:39 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250907185555.GA3530@sol \
--to=ebiggers@kernel.org \
--cc=bharathsm@microsoft.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox